From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Windows: Fix set_unbuffered_mode.o file rename race
Date: Tue, 21 Jul 2026 10:43:36 -0600 [thread overview]
Message-ID: <87cxwgwax3.fsf@tromey.com> (raw)
In-Reply-To: <20260709155657.412594-1-pedro@palves.net> (Pedro Alves's message of "Thu, 9 Jul 2026 16:56:57 +0100")
>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
Pedro> If we get EBUSY, it's because another parallel worker already managed
Pedro> to build and move its set_unbuffered_mode.o copy to the final
Pedro> destination. So fix it by simply ignoring EBUSY. Put the rename in
Pedro> its own procedure, as I expect this will be used in more places.
This looks ok to me, thanks.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2026-07-21 16:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 15:56 Pedro Alves
2026-07-21 16:43 ` Tom Tromey [this message]
2026-07-22 15:07 ` Pedro Alves
2026-07-22 15:20 ` [PATCH] gdb/testsuite: Use file_rename_atomic in gdb_do_cache too Pedro Alves
2026-07-22 15:50 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cxwgwax3.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox