From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qHYTKNLmYGoI2SUAWB0awg (envelope-from ) for ; Wed, 22 Jul 2026 11:50:42 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=eq6okNgz; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 87FA71E033; Wed, 22 Jul 2026 11:50:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EE5BA1E033 for ; Wed, 22 Jul 2026 11:50:41 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5CAA04BA2E0E for ; Wed, 22 Jul 2026 15:50:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5CAA04BA2E0E Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=eq6okNgz Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id E440A4BA2E0E for ; Wed, 22 Jul 2026 15:50:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E440A4BA2E0E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E440A4BA2E0E Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784735418; cv=none; b=glfyeIkTheBHqcAMuSVw4+lkIcb3G5jYskJPYUO4D9iA643F3/Sq0ZLyunv/mwPcCBZHTdLCIjg21KOWTa1FEJ1aFNwfeIrktM0dKW+G+jE6lvNPd+SWSmM7y4bTfZyafzUNZrVbTVmh0xoZ0Ay00/n235YaY7lRFVuo5yZnA2Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784735418; c=relaxed/simple; bh=MAQoyHj3rzcsJackKJxBbPmv3VTOzu+jIxT+iAont/E=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Grzd6bRjOQDxiaxKUVptUWkSS6Xb9C/7dy7WdV9p2N9+N5MVyxqdsHXszLmLtbAe2VzShx04bHnllTs/U/m3FujY5QgeD4S9uHDhhRWQUSpLdvSImf4+4A17UB7NPjPoD9aPuPYXPz2vjiRnGmz1L7okqeHuhFzKde7dscWmFPM= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=eq6okNgz reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E440A4BA2E0E Received: from eig-obgw-5006b.ext.cloudfilter.net ([10.0.29.217]) by cmsmtp with ESMTPS id mYgmwIkokQ4O6mZD7w6Mo4; Wed, 22 Jul 2026 15:50:17 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id mZD6wyOGNWDCxmZD7w4Haw; Wed, 22 Jul 2026 15:50:17 +0000 X-Authority-Analysis: v=2.4 cv=Qpte3Uyd c=1 sm=1 tr=0 ts=6a60e6b9 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=RAioF0-LDSMA:10 a=ItBw4LHWJt0A:10 a=T_Alst9gAAAA:8 a=zstS-IiYAAAA:8 a=yW95WS-4Qt5LKhodR_0A:9 a=DvZ5ixILWSEuw56YIEpp:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=k+m+cccU6PWdgqf35iXRpDTG7o5rxwEniktvMLJ2cjc=; b=eq6okNgzmF2qlgdwLc6afPhu6S jsf3jm4vLDY9zWWUbrGvVA7b04Q3bpjCuHp79nFb+Bqru8otvQ5c4OSb8p9y4OytqjJuugnjf254C m+czF7E/T7ZCXUUpW6jCcoL7g; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:57532 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wmZD6-00000002Ks7-2mNy; Wed, 22 Jul 2026 09:50:16 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: Use file_rename_atomic in gdb_do_cache too In-Reply-To: (Pedro Alves's message of "Wed, 22 Jul 2026 16:20:49 +0100") References: <20260709155657.412594-1-pedro@palves.net> <87cxwgwax3.fsf@tromey.com> <1b0c5cae-df37-4bad-bb77-51464b80cf88@palves.net> X-Attribution: Tom Date: Wed, 22 Jul 2026 09:50:15 -0600 Message-ID: <87v7a7qb0o.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wmZD6-00000002Ks7-2mNy X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:57532 X-Source-Auth: tom+tromey.com X-Email-Count: 13 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfN2GrutTnP06F6R83efyLZo55Ttazi6oVwGYBd50kDxzRcfR8VXsL+fxMgZJSJYs4VwqyLdOgumTNGyThpluYIxAFU4/1vwmp2pbYbD8oOdkgbblPXUr +5QT9ZrjR9uovVkFqaOqdTn+nZ6Gk5+K2YO78dKyaOSV6eswx7gETH5EedtluQDcdA1g4wnWe50sUV085RCohr21OwOIYuoqcxs= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Pedro" == Pedro Alves writes: Pedro> gdb_do_cache in cache.exp does the same thing: in GDB_PARALLEL mode, Pedro> each worker writes the results cache to a per-pid temporary file and Pedro> then atomically renames it into place, so it can hit the same EBUSY Pedro> race on Windows. It was missed by that commit. Pedro> Fix it by using file_rename_atomic there too. Looks good. Approved-By: Tom Tromey Tom