Re: [PATCH v3 7/8] Windows gdb: Implement AVX register support

[Tom Tromey <tom@tromey.com>]

>>>>> "Hannes" == Hannes Domani <ssbssa@yahoo.de> writes:

Hannes> This adds support for the Intel AVX registers on Windows.
Hannes> It enables accessing registers $ymm0 - $ymm15 where they are available.

Hannes> After this patch gdb.arch/i386-avx.exp passes on windows.

I'd like it if Christina would review this.

Hannes> @@ -1339,7 +1339,7 @@ initialize_loadable ()
Hannes>      {
Hannes>        /* Available XState features masked with implemented features.  */
Hannes>        xstate_features = (GetEnabledXStateFeatures ()
Hannes> -			 & X86_XSTATE_SSE_MASK);
Hannes> +			 & X86_XSTATE_AVX_MASK);
Hannes>        /* The extended XState functions are only needed if the available
Hannes>  	 features exceed SSE.  */
Hannes>        if ((xstate_features & ~X86_XSTATE_SSE_MASK) == 0)

Ok, ignore my earlier message for patch 6.  I see what's going on now.

I don't have any problem with this patch.  I'm not certain I totally
understand it, but that's ok.

One thing I did see while doing the background reading is that
supposedly the xstate feature flags are vendor-specific.  So does some
check of the vendor ID need to be done?  I do not know.

thanks,
Tom