Re: [PATCH v3 2/8] Windows gdb: Use allocated buffer for CONTEXT

[Tom Tromey <tom@tromey.com>]

>>>>> "Hannes" == Hannes Domani <ssbssa@yahoo.de> writes:

Hannes> This is done in preparation for the XState functions, because the
Hannes> extended registers are stored directly after the CONTEXT, and its actual
Hannes> size depends on the available XState features.

Looks good, thanks.  I have one note but it's not really super
important.

Approved-By: Tom Tromey <tom@tromey.com>

Hannes> +windows_thread_info::windows_thread_info (windows_process_info *proc_,
Hannes> +					  DWORD tid_, HANDLE h_, CORE_ADDR tlb)
Hannes> +  : proc (proc_),
Hannes> +    tid (tid_),
Hannes> +    h (h_),
Hannes> +    thread_local_base (tlb)
Hannes> +{
Hannes> +#ifdef __x86_64__
Hannes> +  if (proc->wow64_process)
Hannes> +    {
Hannes> +      context_buffer.reset (xmalloc (sizeof (WOW64_CONTEXT)));
Hannes> +      wow64_context = (WOW64_CONTEXT *) context_buffer.get ();
Hannes> +    }
Hannes> +  else
Hannes> +#endif
Hannes> +    {
Hannes> +      context_buffer.reset (xmalloc (sizeof (CONTEXT)));
Hannes> +      context = (CONTEXT *) context_buffer.get ();
Hannes> +    }
Hannes> +  *proc->context_flags_ptr (this) = 0;

I guess this is because the memory isn't initialized?
You could use XCNEW instead of xmalloc to fix this.

Tom