Re: [PATCH v3 6/8] Windows gdb: Get available XState features

[Hannes Domani <ssbssa@yahoo.de>]

 Am Dienstag, 1. September 2026 um 19:38:06 MESZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben:

> >>>>> "Hannes" == Hannes Domani <ssbssa@yahoo.de> writes:
> 
> Hannes> Also prepares the thread context for the additional registers.
> Hannes> ---
> Hannes> v2:
> Hannes>  - Remove PKRU from the implemented features mask
> Hannes> v3:
> Hannes>  - use throw_winerror_with_name instead of error
> Hannes>  - fix formatting and value of xstate_features
> 
> Thanks.
> 
> Hannes> +      /* Available XState features masked with implemented features.  */
> Hannes> +      xstate_features = (GetEnabledXStateFeatures ()
> Hannes> +            & X86_XSTATE_SSE_MASK);
> Hannes> +      /* The extended XState functions are only needed if the available
> Hannes> +    features exceed SSE.  */
> Hannes> +      if ((xstate_features & ~X86_XSTATE_SSE_MASK) == 0)
> Hannes> +    xstate_features = 0;
> 
> Won't this condition always be true?
> Resulting in xstate_features==0 always?

Yes, with this patch xstate_features is still 0.
The next patch then changes the 'and' of the first xstate_features to use
X86_XSTATE_AVX_MASK instead, so it will be possible to have other values.


Hannes