From: Tom Tromey <tromey@redhat.com>
To: Eli Zaretskii <eliz@is.elta.co.il>
Cc: fnasser@redhat.com, gdb-patches@sources.redhat.com
Subject: Re: Patch: complete -vs- duplicates, take 2
Date: Sun, 17 Feb 2002 10:38:00 -0000 [thread overview]
Message-ID: <87u1sgj64r.fsf@creche.redhat.com> (raw)
In-Reply-To: Eli Zaretskii's message of "Sun, 17 Feb 2002 11:10:51 +0200 (IST)"
>>>>> "Eli" == Eli Zaretskii <eliz@is.elta.co.il> writes:
Eli> But I'm still missing something: how do the other changes (in
Eli> cli-cmds.c) avoid removing duplicates twice? I see that you
Eli> added duplicate removal to cli-cmds.c, but how does that prevent
Eli> Readline from doing the same again? What am I missing?
Only the `complete' command calls the code in cli-cmds.c. readline
still calls line_completion_function, which still returns duplicates.
So the duplicate removal code is only run once in either case.
Tom
next prev parent reply other threads:[~2002-02-17 18:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-05 13:23 Tom Tromey
2002-01-25 7:40 ` Fernando Nasser
2002-01-25 10:43 ` Eli Zaretskii
2002-02-14 9:28 ` Tom Tromey
2002-02-17 1:11 ` Eli Zaretskii
2002-02-17 10:38 ` Tom Tromey [this message]
2002-02-17 11:10 ` Eli Zaretskii
2002-02-17 16:51 ` Tom Tromey
2002-02-18 8:06 ` Fernando Nasser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87u1sgj64r.fsf@creche.redhat.com \
--to=tromey@redhat.com \
--cc=eliz@is.elta.co.il \
--cc=fnasser@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox