From: "Eli Zaretskii" <eliz@is.elta.co.il>
To: fnasser@redhat.com
Cc: tromey@redhat.com, gdb-patches@sources.redhat.com
Subject: Re: Patch: complete -vs- duplicates, take 2
Date: Fri, 25 Jan 2002 10:43:00 -0000 [thread overview]
Message-ID: <2950-Fri25Jan2002204302+0200-eliz@is.elta.co.il> (raw)
In-Reply-To: <3C517C33.13B8A9D4@redhat.com> (message from Fernando Nasser on Fri, 25 Jan 2002 10:39:31 -0500)
> Date: Fri, 25 Jan 2002 10:39:31 -0500
> From: Fernando Nasser <fnasser@redhat.com>
>
> It looks OK for me, but I would like Eli's opinion as he is the one who
> has spent more time fixing the completer lately.
>
> Eli?
Tom's idea is okay with me, but I have difficulty reviewing the patch,
because Diff made a terrible salad out of it, probably due to some
false matches in wrong places.
Tom, could you please play with different values of context line
numbers (the NUM parameter in "diff -U NUM"), to produce diffs for
completer.c that would show the real changes, and post just that part
of the patch? (I tried to apply your patch and then produce better
diffs myself, but the patch didn't apply, probably because of version
mismatch between my sources and youirs.)
Thanks.
next prev parent reply other threads:[~2002-01-25 18:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-05 13:23 Tom Tromey
2002-01-25 7:40 ` Fernando Nasser
2002-01-25 10:43 ` Eli Zaretskii [this message]
2002-02-14 9:28 ` Tom Tromey
2002-02-17 1:11 ` Eli Zaretskii
2002-02-17 10:38 ` Tom Tromey
2002-02-17 11:10 ` Eli Zaretskii
2002-02-17 16:51 ` Tom Tromey
2002-02-18 8:06 ` Fernando Nasser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2950-Fri25Jan2002204302+0200-eliz@is.elta.co.il \
--to=eliz@is.elta.co.il \
--cc=fnasser@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox