From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13943 invoked by alias); 25 Jan 2002 18:43:42 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13908 invoked from network); 25 Jan 2002 18:43:38 -0000 Received: from unknown (HELO odin.inter.net.il) (192.114.186.10) by sources.redhat.com with SMTP; 25 Jan 2002 18:43:38 -0000 Received: from zaretsky (diup-218-80.inter.net.il [213.8.218.80]) by odin.inter.net.il (Mirapoint) with ESMTP id AEZ12446; Fri, 25 Jan 2002 20:43:25 +0200 (IST) Date: Fri, 25 Jan 2002 10:43:00 -0000 From: "Eli Zaretskii" To: fnasser@redhat.com Message-Id: <2950-Fri25Jan2002204302+0200-eliz@is.elta.co.il> X-Mailer: emacs 21.2.50 (via feedmail 8 I) and Blat ver 1.8.9 CC: tromey@redhat.com, gdb-patches@sources.redhat.com In-reply-to: <3C517C33.13B8A9D4@redhat.com> (message from Fernando Nasser on Fri, 25 Jan 2002 10:39:31 -0500) Subject: Re: Patch: complete -vs- duplicates, take 2 Reply-to: Eli Zaretskii References: <87666g1nws.fsf@creche.redhat.com> <3C517C33.13B8A9D4@redhat.com> X-SW-Source: 2002-01/txt/msg00737.txt.bz2 > Date: Fri, 25 Jan 2002 10:39:31 -0500 > From: Fernando Nasser > > It looks OK for me, but I would like Eli's opinion as he is the one who > has spent more time fixing the completer lately. > > Eli? Tom's idea is okay with me, but I have difficulty reviewing the patch, because Diff made a terrible salad out of it, probably due to some false matches in wrong places. Tom, could you please play with different values of context line numbers (the NUM parameter in "diff -U NUM"), to produce diffs for completer.c that would show the real changes, and post just that part of the patch? (I tried to apply your patch and then produce better diffs myself, but the patch didn't apply, probably because of version mismatch between my sources and youirs.) Thanks.