From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16261 invoked by alias); 17 Feb 2002 18:38:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16189 invoked from network); 17 Feb 2002 18:38:28 -0000 Received: from unknown (HELO gash2.peakpeak.com) (207.174.178.17) by sources.redhat.com with SMTP; 17 Feb 2002 18:38:28 -0000 Received: from creche.cygnus.com (ta0197.peakpeak.com [204.144.244.197] (may be forged)) by gash2.peakpeak.com (8.9.3/8.9.3) with ESMTP id LAA32542; Sun, 17 Feb 2002 11:25:13 -0700 Received: (from tromey@localhost) by creche.cygnus.com (8.9.3/8.9.3) id LAA08743; Sun, 17 Feb 2002 11:49:24 -0700 To: Eli Zaretskii Cc: fnasser@redhat.com, gdb-patches@sources.redhat.com Subject: Re: Patch: complete -vs- duplicates, take 2 References: <87666g1nws.fsf@creche.redhat.com> <3C517C33.13B8A9D4@redhat.com> <2950-Fri25Jan2002204302+0200-eliz@is.elta.co.il> <87wuxgymst.fsf@creche.redhat.com> <200202170910.LAA24675@is.elta.co.il> From: Tom Tromey Reply-To: tromey@redhat.com X-Attribution: Tom X-Zippy: There's enough money here to buy 5000 cans of Noodle-Roni! Date: Sun, 17 Feb 2002 10:38:00 -0000 In-Reply-To: Eli Zaretskii's message of "Sun, 17 Feb 2002 11:10:51 +0200 (IST)" Message-ID: <87u1sgj64r.fsf@creche.redhat.com> X-Mailer: Gnus v5.7/Emacs 20.5 X-SW-Source: 2002-02/txt/msg00458.txt.bz2 >>>>> "Eli" == Eli Zaretskii writes: Eli> But I'm still missing something: how do the other changes (in Eli> cli-cmds.c) avoid removing duplicates twice? I see that you Eli> added duplicate removal to cli-cmds.c, but how does that prevent Eli> Readline from doing the same again? What am I missing? Only the `complete' command calls the code in cli-cmds.c. readline still calls line_completion_function, which still returns duplicates. So the duplicate removal code is only run once in either case. Tom