From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Use std::vector in type stacks
Date: Sun, 06 Jan 2019 16:40:00 -0000 [thread overview]
Message-ID: <87tvilzqmn.fsf@tromey.com> (raw)
In-Reply-To: <f590f22d0d4b129b8f7bb2a5bcd2c90b@polymtl.ca> (Simon Marchi's message of "Sat, 05 Jan 2019 23:59:02 -0500")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> The = should be on the next line.
[...]
>> @@ -3276,6 +3287,9 @@ c_parse (struct parser_state *par_state)
>> gdb_assert (par_state != NULL);
>> pstate = par_state;
>>
>> + c_parse_state cstate;
>> + scoped_restore cstate_resotre = make_scoped_restore (&cpstate,
>> &cstate);
Simon> "resotre"
Simon> Otherwise, LGTM.
Thanks for the review. I'm checking it in with these fixes.
Tom
next prev parent reply other threads:[~2019-01-06 16:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-05 20:41 [PATCH 0/3] Remove cleanups from c-exp.y Tom Tromey
2019-01-05 20:41 ` [PATCH 2/3] Remove string-related cleanup " Tom Tromey
2019-01-06 5:01 ` Simon Marchi
2019-01-05 20:41 ` [PATCH 1/3] Use std::vector in type stacks Tom Tromey
2019-01-06 4:59 ` Simon Marchi
2019-01-06 16:40 ` Tom Tromey [this message]
2019-01-05 20:41 ` [PATCH 3/3] Remove remaining cleanups from c-exp.y Tom Tromey
2019-01-06 5:04 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvilzqmn.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox