From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Use std::vector in type stacks
Date: Sun, 06 Jan 2019 04:59:00 -0000 [thread overview]
Message-ID: <f590f22d0d4b129b8f7bb2a5bcd2c90b@polymtl.ca> (raw)
In-Reply-To: <20190105204112.26849-2-tom@tromey.com>
On 2019-01-05 15:41, Tom Tromey wrote: }
> @@ -1480,13 +1491,16 @@ parameter_typelist:
> nonempty_typelist
> : type
> {
> - VEC (type_ptr) *typelist = NULL;
> - VEC_safe_push (type_ptr, typelist, $1);
> + std::vector<struct type *> *typelist =
> + new std::vector<struct type *>;
The = should be on the next line.
> @@ -3276,6 +3287,9 @@ c_parse (struct parser_state *par_state)
> gdb_assert (par_state != NULL);
> pstate = par_state;
>
> + c_parse_state cstate;
> + scoped_restore cstate_resotre = make_scoped_restore (&cpstate,
> &cstate);
"resotre"
Otherwise, LGTM.
Simon
next prev parent reply other threads:[~2019-01-06 4:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-05 20:41 [PATCH 0/3] Remove cleanups from c-exp.y Tom Tromey
2019-01-05 20:41 ` [PATCH 2/3] Remove string-related cleanup " Tom Tromey
2019-01-06 5:01 ` Simon Marchi
2019-01-05 20:41 ` [PATCH 1/3] Use std::vector in type stacks Tom Tromey
2019-01-06 4:59 ` Simon Marchi [this message]
2019-01-06 16:40 ` Tom Tromey
2019-01-05 20:41 ` [PATCH 3/3] Remove remaining cleanups from c-exp.y Tom Tromey
2019-01-06 5:04 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f590f22d0d4b129b8f7bb2a5bcd2c90b@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox