From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118483 invoked by alias); 6 Jan 2019 16:40:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118469 invoked by uid 89); 6 Jan 2019 16:40:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.168.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 06 Jan 2019 16:40:20 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 0E87EB206 for ; Sun, 6 Jan 2019 10:40:18 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id gBTGg4bqkiQergBTGg6bey; Sun, 06 Jan 2019 10:40:18 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dzapLa0kfKOH/H/nfKWh6Jn4St2o89hvDC3VgYQBSpE=; b=Hp1nGmyACBS1gcz+Sp+9QUpvTP F1BzCJ8FKMD7krDR6ga+bTKSBJj0Dsh9+nsZXvqmbmh3D0Y6M5PgNeUzOSWk3gbMonmdJWXIv6Lue 2K75YY/2djWqDFDroOaZGbaWr; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:48180 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1ggBTF-000V5R-PN; Sun, 06 Jan 2019 10:40:17 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Use std::vector in type stacks References: <20190105204112.26849-1-tom@tromey.com> <20190105204112.26849-2-tom@tromey.com> Date: Sun, 06 Jan 2019 16:40:00 -0000 In-Reply-To: (Simon Marchi's message of "Sat, 05 Jan 2019 23:59:02 -0500") Message-ID: <87tvilzqmn.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-01/txt/msg00088.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> The = should be on the next line. [...] >> @@ -3276,6 +3287,9 @@ c_parse (struct parser_state *par_state) >> gdb_assert (par_state != NULL); >> pstate = par_state; >> >> + c_parse_state cstate; >> + scoped_restore cstate_resotre = make_scoped_restore (&cpstate, >> &cstate); Simon> "resotre" Simon> Otherwise, LGTM. Thanks for the review. I'm checking it in with these fixes. Tom