From: Tom Tromey <tom@tromey.com>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFAv2 1/4] Add highlight style, title style, fputs_highlighted. Improve 'show style'
Date: Mon, 03 Jun 2019 18:34:00 -0000 [thread overview]
Message-ID: <87tvd6msam.fsf@tromey.com> (raw)
In-Reply-To: <20190601212331.12085-2-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Sat, 1 Jun 2019 23:23:28 +0200")
>>>>> "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:
Philippe> +fputs_highlighted (const char *str, compiled_regex &highlight,
I think this can be "const compiled_regex &". This is ok with this
change (if it's not possible, it is ok without the change).
Tom
next prev parent reply other threads:[~2019-06-03 18:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-01 21:23 [RFAv2 0/4] Improve "show style", have "help" and "apropos" styling their output Philippe Waroquiers
2019-06-01 21:23 ` [RFAv2 4/4] Document in NEWS and gdb.texinfo the "help", "apropos" and "show style" changes Philippe Waroquiers
2019-06-02 2:38 ` Eli Zaretskii
2019-06-02 18:45 ` Philippe Waroquiers
2019-06-01 21:23 ` [RFAv2 2/4] Improve usability and/or readibility of help and apropos output Philippe Waroquiers
2019-06-03 18:35 ` Tom Tromey
2019-06-01 21:23 ` [RFAv2 3/4] Update tests following changes to "help" and "apropos" Philippe Waroquiers
2019-06-03 18:39 ` Tom Tromey
2019-06-01 21:23 ` [RFAv2 1/4] Add highlight style, title style, fputs_highlighted. Improve 'show style' Philippe Waroquiers
2019-06-03 18:34 ` Tom Tromey [this message]
2019-06-03 20:24 ` Philippe Waroquiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvd6msam.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox