From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100539 invoked by alias); 3 Jun 2019 18:34:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100530 invoked by uid 89); 3 Jun 2019 18:34:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.160.12) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Jun 2019 18:34:43 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 3B108189AF for ; Mon, 3 Jun 2019 13:34:42 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Xrn8h4CaD2PzOXrn8hP5UY; Mon, 03 Jun 2019 13:34:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ynbnwOLV1i2Kvi4yciVo/QNXpjChjE3TZe3a8oIPBf0=; b=snnqIT46uI+qxwmD6zU9q5/8rn k7aQSRi79wnvvfDwZtnU91Kx6jHBcBwVjvGMpQFXkRNBEBis/9NKpJ7fbW1yBIaE+TXofxoKumqoV bxt/Wv+xItHsKVtWTY8eQ7qnA; Received: from 174-29-48-168.hlrn.qwest.net ([174.29.48.168]:59682 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hXrn7-0009ua-TC; Mon, 03 Jun 2019 13:34:41 -0500 From: Tom Tromey To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [RFAv2 1/4] Add highlight style, title style, fputs_highlighted. Improve 'show style' References: <20190601212331.12085-1-philippe.waroquiers@skynet.be> <20190601212331.12085-2-philippe.waroquiers@skynet.be> Date: Mon, 03 Jun 2019 18:34:00 -0000 In-Reply-To: <20190601212331.12085-2-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Sat, 1 Jun 2019 23:23:28 +0200") Message-ID: <87tvd6msam.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-06/txt/msg00034.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: Philippe> +fputs_highlighted (const char *str, compiled_regex &highlight, I think this can be "const compiled_regex &". This is ok with this change (if it's not possible, it is ok without the change). Tom