From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFAv2 4/4] Document in NEWS and gdb.texinfo the "help", "apropos" and "show style" changes.
Date: Sun, 02 Jun 2019 18:45:00 -0000 [thread overview]
Message-ID: <1559501146.1454.49.camel@skynet.be> (raw)
In-Reply-To: <83muj0vhih.fsf@gnu.org>
On Sun, 2019-06-02 at 05:38 +0300, Eli Zaretskii wrote:
> > From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> > Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> > Date: Sat, 1 Jun 2019 23:23:31 +0200
> >
> > ---
> > gdb/ChangeLog | 5 +++++
> > gdb/NEWS | 30 ++++++++++++++++++++++++++
> > gdb/doc/ChangeLog | 6 ++++++
> > gdb/doc/gdb.texinfo | 52 +++++++++++++++++++++++++++++++++++++++++++--
> > 4 files changed, 91 insertions(+), 2 deletions(-)
>
> This part is OK, with one comment:
>
> > +@smallexample
> > +@c @group
> > +taas -- Apply a command to all threads (ignoring errors and empty output).
> > +Usage: taas COMMAND
> > +shortcut for 'thread apply all -s COMMAND'
> > +
> > +tfaas -- Apply a command to all frames of all threads (ignoring errors and empty output).
>
> This will most probably produce an overfull line, suggest to break
> into two lines.
Done.
>
> Btw, why did you comment out @group..@end group?
That was a copy/paste of what was just before, I have uncommented
both group instructions.
Thanks for the review
Philippe
next prev parent reply other threads:[~2019-06-02 18:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-01 21:23 [RFAv2 0/4] Improve "show style", have "help" and "apropos" styling their output Philippe Waroquiers
2019-06-01 21:23 ` [RFAv2 4/4] Document in NEWS and gdb.texinfo the "help", "apropos" and "show style" changes Philippe Waroquiers
2019-06-02 2:38 ` Eli Zaretskii
2019-06-02 18:45 ` Philippe Waroquiers [this message]
2019-06-01 21:23 ` [RFAv2 2/4] Improve usability and/or readibility of help and apropos output Philippe Waroquiers
2019-06-03 18:35 ` Tom Tromey
2019-06-01 21:23 ` [RFAv2 3/4] Update tests following changes to "help" and "apropos" Philippe Waroquiers
2019-06-03 18:39 ` Tom Tromey
2019-06-01 21:23 ` [RFAv2 1/4] Add highlight style, title style, fputs_highlighted. Improve 'show style' Philippe Waroquiers
2019-06-03 18:34 ` Tom Tromey
2019-06-03 20:24 ` Philippe Waroquiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559501146.1454.49.camel@skynet.be \
--to=philippe.waroquiers@skynet.be \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox