From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PP?] [PATCH] Remove objfile parameter from abbrev_table::read
Date: Thu, 05 Nov 2020 18:24:58 -0700 [thread overview]
Message-ID: <87tuu3tgyd.fsf@tromey.com> (raw)
In-Reply-To: <ca61696a-d0a3-de38-f430-4ec335b9b1cd@simark.ca> (Simon Marchi's message of "Wed, 4 Nov 2020 20:15:53 -0500")
Simon> LGTM, though I'd add a note in the abbrev_table::read comment, that the
Simon> caller is responsible to make sure the section is read in.
This part was in the patch:
+ offset. The caller is responsible for ensuring that the section
+ has already been read. */
Simon> As well as
Simon> an assert in abbrev_table::read that checks it.
I'll add it.
Tom
next prev parent reply other threads:[~2020-11-06 1:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 23:10 Tom Tromey
2020-11-05 1:15 ` [PP?] " Simon Marchi
2020-11-06 1:24 ` Tom Tromey [this message]
2020-11-06 1:54 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuu3tgyd.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox