From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CBcRJfGlpF8GAgAAWB0awg (envelope-from ) for ; Thu, 05 Nov 2020 20:25:05 -0500 Received: by simark.ca (Postfix, from userid 112) id 947F11F08B; Thu, 5 Nov 2020 20:25:05 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 09D9B1E552 for ; Thu, 5 Nov 2020 20:25:05 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5887B3A47020; Fri, 6 Nov 2020 01:25:04 +0000 (GMT) Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.47.144]) by sourceware.org (Postfix) with ESMTPS id 9298A39F8424 for ; Fri, 6 Nov 2020 01:25:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9298A39F8424 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway22.websitewelcome.com (Postfix) with ESMTP id C172114D3C for ; Thu, 5 Nov 2020 19:25:00 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id aqUukitx2AAk4aqUukLVCs; Thu, 05 Nov 2020 19:25:00 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Qt0W7EoiMtSwx91Y2h4FdAz8hFMyESN9xZOkSY0/Vg4=; b=KdRP6ycjl2VHctMvKSPpVNoMm9 FyO0U3QtZITGS6th3qF4bBGJ1D6aPyHCvY8si9rXrdM/2KOp1MmHmG2jAwaoVpWUp2W778LI+9rCI Hg1eCg+meu0YyWwnGy0bJsIQV; Received: from 97-122-89-243.hlrn.qwest.net ([97.122.89.243]:41070 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kaqUt-001IwM-FR; Thu, 05 Nov 2020 18:24:59 -0700 From: Tom Tromey To: Simon Marchi Subject: Re: [PP?] [PATCH] Remove objfile parameter from abbrev_table::read References: <20201104231056.30808-1-tom@tromey.com> X-Attribution: Tom Date: Thu, 05 Nov 2020 18:24:58 -0700 In-Reply-To: (Simon Marchi's message of "Wed, 4 Nov 2020 20:15:53 -0500") Message-ID: <87tuu3tgyd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.89.243 X-Source-L: No X-Exim-ID: 1kaqUt-001IwM-FR X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-89-243.hlrn.qwest.net (bapiya) [97.122.89.243]:41070 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Simon> LGTM, though I'd add a note in the abbrev_table::read comment, that the Simon> caller is responsible to make sure the section is read in. This part was in the patch: + offset. The caller is responsible for ensuring that the section + has already been read. */ Simon> As well as Simon> an assert in abbrev_table::read that checks it. I'll add it. Tom