From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PP?] [PATCH] Remove objfile parameter from abbrev_table::read
Date: Wed, 4 Nov 2020 20:15:53 -0500 [thread overview]
Message-ID: <ca61696a-d0a3-de38-f430-4ec335b9b1cd@simark.ca> (raw)
In-Reply-To: <20201104231056.30808-1-tom@tromey.com>
On 2020-11-04 6:10 p.m., Tom Tromey wrote:
> In a longer series that I am working on, I needed to remove the
> objfile parameter from abbrev_table::read. It seemed to me that this
> was a simple and relatively harmless patch, so I'm sending it now.
>
> gdb/ChangeLog
> 2020-11-04 Tom Tromey <tom@tromey.com>
>
> * dwarf2/read.c (read_cutu_die_from_dwo)
> (cutu_reader::cutu_reader, cutu_reader::cutu_reader)
> (build_type_psymtabs_1): Update.
> * dwarf2/abbrev.h (struct abbrev_table): Remove objfile
> parameter.
> * dwarf2/abbrev.c (abbrev_table::read): Remove objfile parameter.
> Don't read section.
LGTM, though I'd add a note in the abbrev_table::read comment, that the
caller is responsible to make sure the section is read in. As well as
an assert in abbrev_table::read that checks it.
Simon
next prev parent reply other threads:[~2020-11-05 1:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 23:10 Tom Tromey
2020-11-05 1:15 ` Simon Marchi [this message]
2020-11-06 1:24 ` [PP?] " Tom Tromey
2020-11-06 1:54 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca61696a-d0a3-de38-f430-4ec335b9b1cd@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox