Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org, "Lluís Batlle i Rossell" <viric@viric.name>
Subject: Re: [PATCHv2] gdb: fixes and tests for the 'edit' command
Date: Thu, 07 Nov 2024 08:03:31 -0700	[thread overview]
Message-ID: <87ttcj13y4.fsf@tromey.com> (raw)
In-Reply-To: <c16d9a67489755ae672684ab7c745cd578297384.1730985401.git.aburgess@redhat.com> (Andrew Burgess's message of "Thu, 7 Nov 2024 13:17:27 +0000")

Andrew> I am instead proposing this alternative patch which I think fixes more
Andrew> cases.  When GDB stops at a location then 'edit' with no arguments
Andrew> should correctly edit the current line.  And using 'list XX' to list a
Andrew> specific location, followed by 'edit' should also now edit the just
Andrew> listed location.

Looks good to me.  Thank you.

I think this fixes
https://sourceware.org/bugzilla/show_bug.cgi?id=17669

I also wonder if it fixes
https://sourceware.org/bugzilla/show_bug.cgi?id=8837

Approved-By: Tom Tromey <tom@tromey.com>

Tom

  reply	other threads:[~2024-11-07 15:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-05 22:23 [PATCH] Fix 'edit' command to go to right line Lluís Batlle i Rossell
2024-11-07 11:13 ` Andrew Burgess
2024-11-07 12:01   ` Lluís Batlle i Rossell
2024-11-07 13:22     ` Andrew Burgess
2024-11-07 13:17   ` [PATCHv2] gdb: fixes and tests for the 'edit' command Andrew Burgess
2024-11-07 15:03     ` Tom Tromey [this message]
2024-11-08 10:51       ` Andrew Burgess
2024-11-08 13:28         ` Lluís Batlle i Rossell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttcj13y4.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=viric@viric.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox