Re: Re: [PATCH] Fix 'edit' command to go to right line

[Andrew Burgess <aburgess@redhat.com>]

Lluís Batlle i Rossell <viric@viric.name> writes:

> On Thu, Nov 07, 2024 at 11:13:12AM +0000, Andrew Burgess wrote:
>> Lluís Batlle i Rossell <viric@viric.name> writes:
>> 
>> > I attach this patch I used more than 20 years ago.
>> >
>> > I thought I had sent it in these years but apparently not.
>> > From fc0f3f1200f18c86a6d90185f02b1f5ce0c0235b Mon Sep 17 00:00:00 2001
>> > From: =?UTF-8?q?Llu=C3=ADs=20Batlle=20i=20Rossell?= <viric@viric.name>
>> > Date: Tue, 5 Nov 2024 23:18:30 +0100
>> > Subject: [PATCH] Fix 'edit' command to go to right line
>> >
>> > The cursor was placed at a line off by a bunch of lines.
>> 
>> Thanks for reporting this issue.  I took a look at this patch and
>> started writing some tests for the 'edit' command.  It would seem that
>> this was mostly untested until now!
>> 
>> Anyway, though your patch does fix some cases, I found a bunch more
>> problems, so I'd like to propose the patch below as an alternative.
>> 
>> I hope this should fix the case that I think you care about, though I'm
>> guessing really as you didn't describe exactly which case you believe
>> this fixes.  If you are willing to give this alternative patch a try,
>> and report if this fixes your use case or not that would be really
>> helpful.
>> 
>> Thanks,
>> Andrew
>
> (Now replying Cc to the list)
>
> Sure! Use your patch.
>
> I have EDITOR=vim. And when I'm debugging in some frame, I run 'edit' to
> get me to that position in vim.
>
> I don't really understand what is the get_first_line_listed ()
> situation... I think it means that if 'list' has been run, then the editor
> on 'edit' will point to the line in the middle of the last 'list'.
> I like this as well, if I interpret correctly.

That's correct.  It means I can do:

  (gdb) list SOME_LINE_NUMBER
  (gdb) edit

and GDB will start editing SOME_LINE_NUMBER.  I think we were already
trying to do this, but we were off by 'get_lines_to_list()' in this
case.

I've posted a v2 which fixes some problems with the new test.  I'll
leave this for a while to see if anyone else wants to comment before
merging.

Thanks,
Andrew