From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id C14OKtzWLGeHzigAWB0awg (envelope-from ) for ; Thu, 07 Nov 2024 10:03:56 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=JVEXVqsH; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 536971E603; Thu, 7 Nov 2024 10:03:56 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DEA831E601 for ; Thu, 7 Nov 2024 10:03:54 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7BCC03858CD1 for ; Thu, 7 Nov 2024 15:03:54 +0000 (GMT) Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id F02913858D20 for ; Thu, 7 Nov 2024 15:03:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F02913858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F02913858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730991816; cv=none; b=nZ4zL7E+4Kic+vjhA8i7bLhdXoEKUuGCv4468Q43kfg1NbWiwkXFyFUVdgB/cCAmCob0KHt/bstgJ94mBITNZoy6h9f8uGAuC2Zgn2GckOu2/EBQvol/xjKUP9ybqwoFk/1NHxQ93aETo3IpV5ZHFYJxtN7AuRJYfRQleGlDcks= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730991816; c=relaxed/simple; bh=T/hZ9Q5d60Ql65ozQrWCFQnfVV+Q+ctiAM6Ie/BMvSQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=vgeDBI30I0baQ84oZIgxqBZroMLvWt926Amhmib6+/7qI5BKQQ4uK8KKJ2ytcRAXOD3s5VnGJvwWZcVHjQzYylKRhVTnl6l7SKfpRhFO6CvJQwiOFXuAvGYrKjdIfecTV10DwGmZRkJyheZUtWXtFk/sZeXuD5/MxXu9O9eTb3E= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5008a.ext.cloudfilter.net ([10.0.29.246]) by cmsmtp with ESMTPS id 92gRtlBRbVpzp942ntrwFV; Thu, 07 Nov 2024 15:03:34 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 942ntuv0whpRI942nt3vaK; Thu, 07 Nov 2024 15:03:33 +0000 X-Authority-Analysis: v=2.4 cv=KsJL23WN c=1 sm=1 tr=0 ts=672cd6c5 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VlfZXiiP6vEA:10 a=ItBw4LHWJt0A:10 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=zuSjfic2psc54R3y-WkA:9 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9Vu1fnzpF6HPcgRD1PSLPb1ZjamvYQhmeDU7716Nyag=; b=JVEXVqsHcYdhyOFd8Zcc1orj8T wUDiX+HkPCKkfXxqOoMB+443rvj/2NVM2c52rSD7K0v7ufdDYWX+QV43DOs1D7wSBTbgz+0YFfd30 2cjN/3QAoWbgGzhPz/eA1gReh; Received: from 97-122-113-155.hlrn.qwest.net ([97.122.113.155]:53312 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1t942m-001PUr-2B; Thu, 07 Nov 2024 08:03:32 -0700 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org, =?utf-8?Q?Llu=C3=ADs?= Batlle i Rossell Subject: Re: [PATCHv2] gdb: fixes and tests for the 'edit' command In-Reply-To: (Andrew Burgess's message of "Thu, 7 Nov 2024 13:17:27 +0000") References: <87pln7qotz.fsf@redhat.com> X-Attribution: Tom Date: Thu, 07 Nov 2024 08:03:31 -0700 Message-ID: <87ttcj13y4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.113.155 X-Source-L: No X-Exim-ID: 1t942m-001PUr-2B X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-113-155.hlrn.qwest.net (murgatroyd) [97.122.113.155]:53312 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfKpS9UEknracLa8dt3PFWWbsen0OhCPD893rjxR2eUD1WACgXY0sNBXOGbLjVRFh7wN9Ermq9Mi+nsnSQupyXThS+GGOihj9TLYZWwJ2NAGocCvtM4ml Hz0D3ZOwxm2CbueMqixlIjQPwuGxJmazyqdz2v24bKuUzBTbpeEq6ThjclDIpVS69RA81iLMfRp7CLQbiFNwuo+mse/5l76Uobs= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Andrew> I am instead proposing this alternative patch which I think fixes more Andrew> cases. When GDB stops at a location then 'edit' with no arguments Andrew> should correctly edit the current line. And using 'list XX' to list a Andrew> specific location, followed by 'edit' should also now edit the just Andrew> listed location. Looks good to me. Thank you. I think this fixes https://sourceware.org/bugzilla/show_bug.cgi?id=17669 I also wonder if it fixes https://sourceware.org/bugzilla/show_bug.cgi?id=8837 Approved-By: Tom Tromey Tom