Re: [PATCH][PR symtab/32658] Fix parsing .debug_aranges section for MIPS signed addresses

[Tom Tromey <tom@tromey.com>]

>>>>> "Martin" == Martin Simmons <qqxnjvamvxwx@dyxyl.com> writes:

Martin> This patch fixes https://sourceware.org/bugzilla/show_bug.cgi?id=32658 by sign

There should be a 'Bug: ...' trailer in the comment with this link.

FWIW I see now that other spots in the DWARF reader do use the BFD
approach:

  int signed_addr_p = bfd_get_sign_extend_vma (objfile->obfd.get ());

Martin> I made it explicitly sign extend the addresses after they are read
Martin> (instead of using extract_signed_integer) because I don't know if the
Martin> address_size in the section will always be equal to the gdb arch_size.

I don't think this should be a concern, unless you have an example where
it actually happens.

The .debug_aranges header spec explicitly says "size of an address in
bytes on the target architecture".

Tom