From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id tdDVDKj72mcp3hQAWB0awg (envelope-from ) for ; Wed, 19 Mar 2025 13:15:20 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=BELSh6z1; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 221841E100; Wed, 19 Mar 2025 13:15:20 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4BE011E0C0 for ; Wed, 19 Mar 2025 13:15:19 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2A6F7385781B for ; Wed, 19 Mar 2025 17:15:18 +0000 (GMT) Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 0FAAB3858431 for ; Wed, 19 Mar 2025 16:48:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0FAAB3858431 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0FAAB3858431 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742402893; cv=none; b=AmF8qAvOGRrd8yF5YOk5jB1IvG6BagE+otM46ktN2z80mVZOwSM64hdc9P68Ow86di6T7uZ3crxYGQsb3CQoKhwUUNLnsOzhaqeq5sd7kkRsZIPFnBfUc/0PtHoRY8EmDaYybmxoLcoObEYOGSTqLucqrJvO3vRCByu6AOP5gz4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742402893; c=relaxed/simple; bh=oqZ6I7fVB/oR0Xdzfr+PbeNAi9djRpMrd8k4cf60AlA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ADd+PmdNHMbRtITeLcb7lQEnC3VTaawgwr0XXDo0yXnguZ+0EHlNTo0v44D5WVm26t6VCPEfUAdl7LNs1vkUx7uVe3JNGIXXY8H6bwKZrr2gAFwetO58xSV9wxomWnh1ga80r5IuFzJs8ePK5FxAjWT8X2Wyam6UpdjDobdrEQk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0FAAB3858431 Authentication-Results: sourceware.org; dkim=policy reason="signing key too small" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=BELSh6z1 Received: from eig-obgw-5009a.ext.cloudfilter.net ([10.0.29.176]) by cmsmtp with ESMTPS id uuABtbopBVkcRuwaStPfB2; Wed, 19 Mar 2025 16:48:12 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id uwaRt6iHaaBenuwaSt8s2Y; Wed, 19 Mar 2025 16:48:12 +0000 X-Authority-Analysis: v=2.4 cv=I7xjRsgg c=1 sm=1 tr=0 ts=67daf54c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Vs1iUdzkB0EA:10 a=ItBw4LHWJt0A:10 a=CCpqsmhAAAAA:8 a=yf-9_7nDAAAA:8 a=-BhWxDXrmB_pjyHO7g4A:9 a=ul9cdbp4aOFLsgKbc677:22 a=83x-OuSItBAdxQCf2ADw:22 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=RjJlpDgbqWpK2Zl+Ok3r+9Siu3Q2jTMWci+Sw6lfNwE=; b=BELSh6z1vKoh9dvUHHip9ZiPoT Pp8s6QaDEgkrukPmPe9/Slzs7O7AGo+AoR5S63VuqodzvDzPynKYIqWyeBKE5xtzVXwQyLphFQrVd Qr0p6U7fYSUR+TkAvsnfAM59W; Received: from 97-122-123-18.hlrn.qwest.net ([97.122.123.18]:52144 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1tuwaR-000000027KT-1Z3L; Wed, 19 Mar 2025 10:48:11 -0600 From: Tom Tromey To: Martin Simmons Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][PR symtab/32658] Fix parsing .debug_aranges section for MIPS signed addresses In-Reply-To: <20250307235722.1D4CDEE05D@localhost.localdomain> (Martin Simmons's message of "Fri, 7 Mar 2025 23:57:22 +0000 (GMT)") References: <20250307235722.1D4CDEE05D@localhost.localdomain> X-Attribution: Tom Date: Wed, 19 Mar 2025 10:48:09 -0600 Message-ID: <87tt7pj7au.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.123.18 X-Source-L: No X-Exim-ID: 1tuwaR-000000027KT-1Z3L X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-123-18.hlrn.qwest.net (murgatroyd) [97.122.123.18]:52144 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCKFFpxesh79tNo6RfCJKfJWClgfVAZkXWLBmXgofDOv/5YYl0SFL93kX3/jLEXg6Jk0DM3B6L2nm7mDMM4pLUGilOJhsxt9jOQ04nXljRVCla1cW78Y Fi4ao6BMpg8GB4p0T7lelb/kWXqfzJ5pNbjSp5ttZzlUOAkhWCE0BHB1J9SdeChJTRQ4SGRK0zpQa8vkkhJvvhVmBpHBQSf+Lk8= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Martin" == Martin Simmons writes: Martin> This patch fixes https://sourceware.org/bugzilla/show_bug.cgi?id=32658 by sign There should be a 'Bug: ...' trailer in the comment with this link. FWIW I see now that other spots in the DWARF reader do use the BFD approach: int signed_addr_p = bfd_get_sign_extend_vma (objfile->obfd.get ()); Martin> I made it explicitly sign extend the addresses after they are read Martin> (instead of using extract_signed_integer) because I don't know if the Martin> address_size in the section will always be equal to the gdb arch_size. I don't think this should be a concern, unless you have an example where it actually happens. The .debug_aranges header spec explicitly says "size of an address in bytes on the target architecture". Tom