From: Martin Simmons <qqxnjvamvxwx@dyxyl.com>
To: Tom Tromey <tom@tromey.com>
Cc: qqxnjvamvxwx@dyxyl.com, gdb-patches@sourceware.org
Subject: {Spam?} Re: [PATCH][PR symtab/32658] Fix parsing .debug_aranges section for MIPS signed addresses
Date: Sun, 09 Mar 2025 20:40:04 +0000 [thread overview]
Message-ID: <jeldteos4b.fsf@localhost> (raw)
In-Reply-To: <87frjno4t1.fsf@tromey.com> (message from Tom Tromey on Sat, 08 Mar 2025 09:39:06 -0700)
>>>>> On Sat, 08 Mar 2025 09:39:06 -0700, Tom Tromey said:
>
>>>>> "Martin" == Martin Simmons <qqxnjvamvxwx@dyxyl.com> writes:
>
> Martin> This patch fixes https://sourceware.org/bugzilla/show_bug.cgi?id=32658 by sign
> Martin> extending the addresses read from the .debug_aranges section as required for
> Martin> MIPS. I made it explicitly sign extend the addresses after they are read
> Martin> (instead of using extract_signed_integer) because I don't know if the
> Martin> address_size in the section will always be equal to the gdb arch_size.
>
> I wonder if perhaps the relevant gdbarch method should be used instead.
Do you mean gdbarch_integer_to_address like in
dwarf_expr_context::fetch_address? I considered that, but it looked
like a kludge and it wasn't clear to me if that would be good for avr
(calling avr_integer_to_address).
Also, the old parser used comp_unit_head::read_address (called from
dwarf_decode_lines_1) so that didn't do anything with gdbarch.
__Martin
next prev parent reply other threads:[~2025-03-09 20:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 23:57 Martin Simmons
2025-03-08 16:39 ` Tom Tromey
2025-03-09 20:40 ` Martin Simmons [this message]
2025-03-19 16:42 ` {Spam?} " Tom Tromey
2025-03-19 16:48 ` Tom Tromey
2025-03-27 16:03 ` [PATCH v2][PR " Martin Simmons
2025-04-03 15:03 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jeldteos4b.fsf@localhost \
--to=qqxnjvamvxwx@dyxyl.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox