From: Tom Tromey <tom@tromey.com>
To: Jan Vrany <jan.vrany@labware.com>
Cc: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v3] gdb/python: add property ranges to gdb.Block object
Date: Thu, 19 Mar 2026 09:12:18 -0600 [thread overview]
Message-ID: <87tsubam5p.fsf@tromey.com> (raw)
In-Reply-To: <20260313144019.273153-1-jan.vrany@labware.com> (Jan Vrany's message of "Fri, 13 Mar 2026 14:40:19 +0000")
>>>>> "Jan" == Jan Vrany <jan.vrany@labware.com> writes:
>> Or maybe be written in some other way.
Jan> I tried to use "(OO)", gdb_py_object_from_ulongest(start),
Jan> gdb_py_object_from_ulongest(end) but that did not look
Jan> significantly better to me.
Yeah, until the safety changes, this would need extra checking as well
anyway.
Jan> This commit adds a new property - ranges - to gdb.Block object. It holds
Jan> a tuple of ranges for that block. Each range is a tuple of (start, end)
Jan> address. For contiguous blocks it contains only one range.
This version looks good to me, thank you.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2026-03-19 15:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 20:18 [PATCH] " Jan Vrany
2026-03-12 6:52 ` Eli Zaretskii
2026-03-12 11:04 ` Jan Vraný
2026-03-12 11:35 ` Eli Zaretskii
2026-03-12 12:35 ` Tom Tromey
2026-03-12 14:33 ` [PATCH v2] " Jan Vrany
2026-03-12 15:15 ` Tom Tromey
2026-03-13 14:40 ` [PATCH v3] " Jan Vrany
2026-03-19 15:12 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tsubam5p.fsf@tromey.com \
--to=tom@tromey.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.vrany@labware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox