Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jan Vrany <jan.vrany@labware.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/python: add property ranges to gdb.Block object
Date: Thu, 12 Mar 2026 08:52:23 +0200	[thread overview]
Message-ID: <86zf4dedzs.fsf@gnu.org> (raw)
In-Reply-To: <20260311201826.2244014-1-jan.vrany@labware.com> (message from Jan Vrany on Wed, 11 Mar 2026 20:18:26 +0000)

> From: Jan Vrany <jan.vrany@labware.com>
> CC: Jan Vrany <jan.vrany@labware.com>
> Date: Wed, 11 Mar 2026 20:18:26 +0000
> 
> This commit adds a new property - ranges - to gdb.Block object. It holds
> a tuple of ranges for that block. Each range is a tuple of (start, end)
> address. For contiguous blocks it contains only one range.
> ---
>  gdb/NEWS                              |  4 ++++
>  gdb/doc/python.texi                   |  7 +++++++
>  gdb/python/py-block.c                 | 30 +++++++++++++++++++++++++++
>  gdb/testsuite/gdb.python/py-block.exp |  3 +++
>  4 files changed, 44 insertions(+)

Thanks.

> +  ** New gdb.Block.ranges attribute.  This read only attribute contains
> +     a tuple of pairs each representing a single range. Contiguous blocks
> +     have only one range.                             ^^

Two spaces there, please.

> +@defvar Block.ranges
> +A tuple representing address ranges of the block.  Each range is represented
> +as pair (two-element tuple) where first element is the start of the range
   ^^^^^^^                           ^^^^^^^^^^^^^
"as a pair" and "the first element"

> +and second element is one past the last address that appears in the range.
       ^^^^^^^^^^^^^^
"the second element"

> +The order of ranges is unspecified. Contiguous blocks have only one range.
> +This attribute is not writable.   ^^

Two spaces there.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>

  reply	other threads:[~2026-03-12  6:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 20:18 Jan Vrany
2026-03-12  6:52 ` Eli Zaretskii [this message]
2026-03-12 11:04   ` Jan Vraný
2026-03-12 11:35     ` Eli Zaretskii
2026-03-12 12:35 ` Tom Tromey
2026-03-12 14:33   ` [PATCH v2] " Jan Vrany
2026-03-12 15:15     ` Tom Tromey
2026-03-13 14:40       ` [PATCH v3] " Jan Vrany
2026-03-19 15:12         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86zf4dedzs.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.vrany@labware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox