Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Jan Vrany <jan.vrany@labware.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/python: add property ranges to gdb.Block object
Date: Thu, 12 Mar 2026 06:35:47 -0600	[thread overview]
Message-ID: <87bjgttecc.fsf@tromey.com> (raw)
In-Reply-To: <20260311201826.2244014-1-jan.vrany@labware.com> (Jan Vrany's message of "Wed, 11 Mar 2026 20:18:26 +0000")

Jan> +  const struct block *block = NULL;

In new code we're writing 'nullptr'

Jan> +  if (ranges.size() == 0)

Space before "(".

Jan> +      gdbpy_ref<> ranges_obj (PyTuple_New (ranges.size ()));

Error check.

Jan> +	  gdbpy_ref<> range_obj (Py_BuildValue ("(KK)", ranges[i].start (),
Jan> +						ranges[i].end ()));

Another error check.

Someday maybe we'll land the "safety" approach and this stuff will be easier.

thanks,
Tom

  parent reply	other threads:[~2026-03-12 12:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 20:18 Jan Vrany
2026-03-12  6:52 ` Eli Zaretskii
2026-03-12 11:04   ` Jan Vraný
2026-03-12 11:35     ` Eli Zaretskii
2026-03-12 12:35 ` Tom Tromey [this message]
2026-03-12 14:33   ` [PATCH v2] " Jan Vrany
2026-03-12 15:15     ` Tom Tromey
2026-03-13 14:40       ` [PATCH v3] " Jan Vrany
2026-03-19 15:12         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bjgttecc.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.vrany@labware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox