From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: RFC: fix bug in compare_breakpoints
Date: Wed, 17 Oct 2012 19:36:00 -0000 [thread overview]
Message-ID: <87sj9c28o1.fsf@fleche.redhat.com> (raw)
I built gdb with clang today.
This found a bunch of nits (I'll send a nit-cleanup patch later) but
also a couple real bugs.
Here's the first one. compare_breakpoints has an invalid comparison.
Built (with clang and gcc) and regtested (gcc only) on x86-64 F16.
Tom
2012-10-17 Tom Tromey <tromey@redhat.com>
* breakpoint.c (compare_breakpoints): Fix comparison.
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index bebad75..76e3e89 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -11766,7 +11766,7 @@ compare_breakpoints (const void *a, const void *b)
the number 0. */
if (ua < ub)
return -1;
- return ub > ub ? 1 : 0;
+ return ua > ub ? 1 : 0;
}
/* Delete breakpoints by address or line. */
next reply other threads:[~2012-10-17 19:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 19:36 Tom Tromey [this message]
2012-10-17 21:25 ` Joel Brobecker
2012-10-18 20:07 ` Tom Tromey
2012-10-18 8:53 ` Pedro Alves
2012-10-18 20:06 ` Tom Tromey
2012-10-19 16:17 ` Tom Tromey
2012-10-19 16:41 ` Add -Wempty-body to warning set (was: Re: RFC: fix bug in compare_breakpoints) Pedro Alves
2012-10-19 16:44 ` Add -Wempty-body to warning set Tom Tromey
2012-10-19 17:00 ` RFC: fix bug in compare_breakpoints Joel Brobecker
2012-10-19 17:03 ` Tom Tromey
2012-10-19 17:12 ` Joel Brobecker
2012-10-19 17:18 ` Pedro Alves
2012-11-02 18:52 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sj9c28o1.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox