From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: fix bug in compare_breakpoints
Date: Thu, 18 Oct 2012 20:06:00 -0000 [thread overview]
Message-ID: <87lif3y27l.fsf@fleche.redhat.com> (raw)
In-Reply-To: <507FC362.5070906@redhat.com> (Pedro Alves's message of "Thu, 18 Oct 2012 09:52:50 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> Eh! Shame that gcc doesn't warn on this ("comparison always false",
Pedro> I gather?). Sounds like something that shouldn't be hard for the
Pedro> compiler to detect. IWBN to have gcc PRs for these issues.
I filed http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54979
for the comparison issue.
The other problem is caught by -Wempty-body, which we don't enable. It
yields a number of warnings and would require a coding style change
from:
if (blah)
;
to
if (blah)
{
}
That would be fine with me, and I'd be happy to write the patch if there
is general agreement.
Tom
next prev parent reply other threads:[~2012-10-18 20:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 19:36 Tom Tromey
2012-10-17 21:25 ` Joel Brobecker
2012-10-18 20:07 ` Tom Tromey
2012-10-18 8:53 ` Pedro Alves
2012-10-18 20:06 ` Tom Tromey [this message]
2012-10-19 16:17 ` Tom Tromey
2012-10-19 16:41 ` Add -Wempty-body to warning set (was: Re: RFC: fix bug in compare_breakpoints) Pedro Alves
2012-10-19 16:44 ` Add -Wempty-body to warning set Tom Tromey
2012-10-19 17:00 ` RFC: fix bug in compare_breakpoints Joel Brobecker
2012-10-19 17:03 ` Tom Tromey
2012-10-19 17:12 ` Joel Brobecker
2012-10-19 17:18 ` Pedro Alves
2012-11-02 18:52 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lif3y27l.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox