From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: RFC: fix bug in compare_breakpoints
Date: Fri, 19 Oct 2012 17:12:00 -0000 [thread overview]
Message-ID: <20121019171239.GY3050@adacore.com> (raw)
In-Reply-To: <87sj9av1hg.fsf@fleche.redhat.com>
> A few are just to stick a comment there, and some others are to work
> around warn_unused_result.
Yeah. In the first case, we could move the comment back to the top,
although perhaps it's easier to read an understand the current way.
I also saw the ones around "warn_unused_result" and we could have
used a cast to (void), I suppose. But in the end, all of this isn't
really all that important. Gives us an opportunity to request a comment
explaining why it's OK to ignore the return value :-).
--
Joel
next prev parent reply other threads:[~2012-10-19 17:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 19:36 Tom Tromey
2012-10-17 21:25 ` Joel Brobecker
2012-10-18 20:07 ` Tom Tromey
2012-10-18 8:53 ` Pedro Alves
2012-10-18 20:06 ` Tom Tromey
2012-10-19 16:17 ` Tom Tromey
2012-10-19 16:41 ` Add -Wempty-body to warning set (was: Re: RFC: fix bug in compare_breakpoints) Pedro Alves
2012-10-19 16:44 ` Add -Wempty-body to warning set Tom Tromey
2012-10-19 17:00 ` RFC: fix bug in compare_breakpoints Joel Brobecker
2012-10-19 17:03 ` Tom Tromey
2012-10-19 17:12 ` Joel Brobecker [this message]
2012-10-19 17:18 ` Pedro Alves
2012-11-02 18:52 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121019171239.GY3050@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox