From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: fix PR symtab/11464
Date: Mon, 11 Feb 2013 20:45:00 -0000 [thread overview]
Message-ID: <87sj52poky.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20130211203930.GA26149@host2.jankratochvil.net> (Jan Kratochvil's message of "Mon, 11 Feb 2013 21:39:30 +0100")
Jan> That's true, that crashes even for me. I still expected it crashes
Jan> for you if you remove the two lines:
Jan> if (classification == NAME)
Jan> break;
Jan> which cannot / does not crash.
I thought you were reporting that the test case did not crash before the
fix.
Now I don't understand what you are saying here.
>> I guess you are saying I should invert the if.
>> Ok, I will do that.
Jan> No, I did not mean that. In fact I do not understand much what condition
Jan> inversion do you mean.
I mean now the patch reads:
if (classification != NAME)
context_type = yylval.tsym.type;
This still fixes the failing test case, but I haven't run it through a
complete regression test yet.
Tom
next prev parent reply other threads:[~2013-02-11 20:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 19:51 Tom Tromey
2013-02-03 5:45 ` Jan Kratochvil
2013-02-04 16:33 ` Tom Tromey
2013-02-04 21:47 ` Tom Tromey
2013-02-07 19:15 ` Jan Kratochvil
2013-02-11 20:28 ` Tom Tromey
2013-02-11 20:39 ` Jan Kratochvil
2013-02-11 20:45 ` Tom Tromey [this message]
2013-02-11 20:58 ` Jan Kratochvil
2013-02-12 20:20 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sj52poky.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox