From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: fix PR symtab/11464
Date: Sun, 03 Feb 2013 05:45:00 -0000 [thread overview]
Message-ID: <20130203054502.GB16948@host2.jankratochvil.net> (raw)
In-Reply-To: <87hamovmu7.fsf@fleche.redhat.com>
On Thu, 10 Jan 2013 20:50:56 +0100, Tom Tromey wrote:
> 2013-01-10 Tom Tromey <tromey@redhat.com>
>
> PR symtab/11464:
> * c-exp.y (lex_one_token): Initialize other fields of yylval on
> NAME return.
> (classify_inner_name): Remove 'first_name' argument, add
> 'context'. Remove unused variable.
> (yylex): Explicitly maintain the context type. Exit loop earlier
> if NAME result is seen.
>
> 2013-01-10 Tom Tromey <tromey@redhat.com>
>
> * gdb.cp/m-static.cc (gnu_obj_1::~gnu_obj_1): New destructor.
> * gdb.cp/m-static.exp: Add tests to print quoted destructor.
I do not see there a regression; this does not mean much for c-exp.y.
>
> diff --git a/gdb/c-exp.y b/gdb/c-exp.y
> index 9847120..9ef4b39 100644
> --- a/gdb/c-exp.y
> +++ b/gdb/c-exp.y
> @@ -2978,6 +2985,11 @@ yylex (void)
> current.token = classification;
>
> last_was_coloncolon = 0;
> +
> + if (classification == NAME)
> + break;
IIUC this is a parsing cleanup unrelated to this bug.
> +
> + context_type = yylval.tsym.type;
> }
> else if (next.token == COLONCOLON && !last_was_coloncolon)
> last_was_coloncolon = 1;
Thanks,
Jan
next prev parent reply other threads:[~2013-02-03 5:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 19:51 Tom Tromey
2013-02-03 5:45 ` Jan Kratochvil [this message]
2013-02-04 16:33 ` Tom Tromey
2013-02-04 21:47 ` Tom Tromey
2013-02-07 19:15 ` Jan Kratochvil
2013-02-11 20:28 ` Tom Tromey
2013-02-11 20:39 ` Jan Kratochvil
2013-02-11 20:45 ` Tom Tromey
2013-02-11 20:58 ` Jan Kratochvil
2013-02-12 20:20 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130203054502.GB16948@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox