From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13429 invoked by alias); 3 Feb 2013 05:45:26 -0000 Received: (qmail 13406 invoked by uid 22791); 3 Feb 2013 05:45:25 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_YY X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 03 Feb 2013 05:45:13 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r135jCi3006048 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 3 Feb 2013 00:45:12 -0500 Received: from host2.jankratochvil.net ([10.3.113.16]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r135j3ql022610 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sun, 3 Feb 2013 00:45:10 -0500 Date: Sun, 03 Feb 2013 05:45:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: RFC: fix PR symtab/11464 Message-ID: <20130203054502.GB16948@host2.jankratochvil.net> References: <87hamovmu7.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87hamovmu7.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00051.txt.bz2 On Thu, 10 Jan 2013 20:50:56 +0100, Tom Tromey wrote: > 2013-01-10 Tom Tromey > > PR symtab/11464: > * c-exp.y (lex_one_token): Initialize other fields of yylval on > NAME return. > (classify_inner_name): Remove 'first_name' argument, add > 'context'. Remove unused variable. > (yylex): Explicitly maintain the context type. Exit loop earlier > if NAME result is seen. > > 2013-01-10 Tom Tromey > > * gdb.cp/m-static.cc (gnu_obj_1::~gnu_obj_1): New destructor. > * gdb.cp/m-static.exp: Add tests to print quoted destructor. I do not see there a regression; this does not mean much for c-exp.y. > > diff --git a/gdb/c-exp.y b/gdb/c-exp.y > index 9847120..9ef4b39 100644 > --- a/gdb/c-exp.y > +++ b/gdb/c-exp.y > @@ -2978,6 +2985,11 @@ yylex (void) > current.token = classification; > > last_was_coloncolon = 0; > + > + if (classification == NAME) > + break; IIUC this is a parsing cleanup unrelated to this bug. > + > + context_type = yylval.tsym.type; > } > else if (next.token == COLONCOLON && !last_was_coloncolon) > last_was_coloncolon = 1; Thanks, Jan