From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6244 invoked by alias); 11 Feb 2013 20:45:26 -0000 Received: (qmail 6217 invoked by uid 22791); 11 Feb 2013 20:45:25 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Feb 2013 20:45:14 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1BKjDdq018380 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 11 Feb 2013 15:45:13 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r1BKj2fs007872 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 11 Feb 2013 15:45:04 -0500 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: RFC: fix PR symtab/11464 References: <87hamovmu7.fsf@fleche.redhat.com> <20130203054502.GB16948@host2.jankratochvil.net> <871ucw2g4p.fsf@fleche.redhat.com> <87fw1bzr8m.fsf@fleche.redhat.com> <20130207191514.GA24179@host2.jankratochvil.net> <87zjzappd6.fsf@fleche.redhat.com> <20130211203930.GA26149@host2.jankratochvil.net> Date: Mon, 11 Feb 2013 20:45:00 -0000 In-Reply-To: <20130211203930.GA26149@host2.jankratochvil.net> (Jan Kratochvil's message of "Mon, 11 Feb 2013 21:39:30 +0100") Message-ID: <87sj52poky.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00259.txt.bz2 Jan> That's true, that crashes even for me. I still expected it crashes Jan> for you if you remove the two lines: Jan> if (classification == NAME) Jan> break; Jan> which cannot / does not crash. I thought you were reporting that the test case did not crash before the fix. Now I don't understand what you are saying here. >> I guess you are saying I should invert the if. >> Ok, I will do that. Jan> No, I did not mean that. In fact I do not understand much what condition Jan> inversion do you mean. I mean now the patch reads: if (classification != NAME) context_type = yylval.tsym.type; This still fixes the failing test case, but I haven't run it through a complete regression test yet. Tom