Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
Subject: Re: [RFA] Change machoread.c to use std::vector
Date: Sat, 17 Mar 2018 19:14:00 -0000	[thread overview]
Message-ID: <87sh8yqzub.fsf@tromey.com> (raw)
In-Reply-To: <720f844f-639f-0f45-7399-a34b4822724e@simark.ca> (Simon Marchi's	message of "Sat, 17 Mar 2018 13:28:16 -0400")

Simon> I suppose running the testsuite on macOS would test it?  Though I'm not
Simon> sure the current state of macOS support allows that...

I don't have access to a Mac.

Maybe if one were available the test suite could be run using lldb's
gdbserver-like thing -- that would avoid the code-signing problem.

>> +          for (last_ix = ix; ix < oso_vector_ptr->size (); last_ix++)

Simon> "ix < " or "last_ix < "?

Ugh.  Thanks.

Another idea would be to check in a macho object file or two, just for
smoke tests.

Tom


  reply	other threads:[~2018-03-17 19:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-17 15:46 Tom Tromey
2018-03-17 17:28 ` Simon Marchi
2018-03-17 19:14   ` Tom Tromey [this message]
2018-03-17 19:35     ` Tom Tromey
2018-03-18 23:27       ` Joel Brobecker
2018-03-19 15:37         ` Tom Tromey
2018-03-20  8:53           ` Xavier Roirand
2018-03-21 21:32             ` Tom Tromey
2018-03-22 16:52               ` Joel Brobecker
2018-03-23 16:03                 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sh8yqzub.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox