From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Change machoread.c to use std::vector
Date: Sat, 17 Mar 2018 17:28:00 -0000 [thread overview]
Message-ID: <720f844f-639f-0f45-7399-a34b4822724e@simark.ca> (raw)
In-Reply-To: <20180317154629.1315-1-tom@tromey.com>
On 2018-03-17 11:46 AM, Tom Tromey wrote:
> This changes machoread.c to use std::vector rather than VEC. This
> allows removing some cleanups.
>
> Regression tested by the buildbot, though I don't think anything
> actually tests macho reading.
I suppose running the testsuite on macOS would test it? Though I'm not
sure the current state of macOS support allows that...
I noted one comment below.
> @@ -654,9 +639,9 @@ macho_symfile_read_all_oso (VEC (oso_el) **oso_vector_ptr,
> std::string archive_name (oso->name, pfx_len);
>
> /* Compute number of oso for this archive. */
> - for (last_ix = ix;
> - VEC_iterate (oso_el, vec, last_ix, oso2); last_ix++)
> + for (last_ix = ix; ix < oso_vector_ptr->size (); last_ix++)
"ix < " or "last_ix < "?
Simon
next prev parent reply other threads:[~2018-03-17 17:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-17 15:46 Tom Tromey
2018-03-17 17:28 ` Simon Marchi [this message]
2018-03-17 19:14 ` Tom Tromey
2018-03-17 19:35 ` Tom Tromey
2018-03-18 23:27 ` Joel Brobecker
2018-03-19 15:37 ` Tom Tromey
2018-03-20 8:53 ` Xavier Roirand
2018-03-21 21:32 ` Tom Tromey
2018-03-22 16:52 ` Joel Brobecker
2018-03-23 16:03 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=720f844f-639f-0f45-7399-a34b4822724e@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox