From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115206 invoked by alias); 17 Mar 2018 17:28:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115195 invoked by uid 89); 17 Mar 2018 17:28:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 17 Mar 2018 17:28:18 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4CE291E4B2; Sat, 17 Mar 2018 13:28:17 -0400 (EDT) Subject: Re: [RFA] Change machoread.c to use std::vector To: Tom Tromey , gdb-patches@sourceware.org References: <20180317154629.1315-1-tom@tromey.com> From: Simon Marchi Message-ID: <720f844f-639f-0f45-7399-a34b4822724e@simark.ca> Date: Sat, 17 Mar 2018 17:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180317154629.1315-1-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-03/txt/msg00336.txt.bz2 On 2018-03-17 11:46 AM, Tom Tromey wrote: > This changes machoread.c to use std::vector rather than VEC. This > allows removing some cleanups. > > Regression tested by the buildbot, though I don't think anything > actually tests macho reading. I suppose running the testsuite on macOS would test it? Though I'm not sure the current state of macOS support allows that... I noted one comment below. > @@ -654,9 +639,9 @@ macho_symfile_read_all_oso (VEC (oso_el) **oso_vector_ptr, > std::string archive_name (oso->name, pfx_len); > > /* Compute number of oso for this archive. */ > - for (last_ix = ix; > - VEC_iterate (oso_el, vec, last_ix, oso2); last_ix++) > + for (last_ix = ix; ix < oso_vector_ptr->size (); last_ix++) "ix < " or "last_ix < "? Simon