From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12952 invoked by alias); 17 Mar 2018 19:14:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12942 invoked by uid 89); 17 Mar 2018 19:14:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=smoke X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.145.221) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 17 Mar 2018 19:14:23 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway33.websitewelcome.com (Postfix) with ESMTP id EB3D41C2A7C for ; Sat, 17 Mar 2018 14:14:21 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id xHHZetGtCE0sxxHHZerrwJ; Sat, 17 Mar 2018 14:14:21 -0500 Received: from 174-29-60-18.hlrn.qwest.net ([174.29.60.18]:52496 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1exHHZ-0012PF-NF; Sat, 17 Mar 2018 14:14:21 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA] Change machoread.c to use std::vector References: <20180317154629.1315-1-tom@tromey.com> <720f844f-639f-0f45-7399-a34b4822724e@simark.ca> Date: Sat, 17 Mar 2018 19:14:00 -0000 In-Reply-To: <720f844f-639f-0f45-7399-a34b4822724e@simark.ca> (Simon Marchi's message of "Sat, 17 Mar 2018 13:28:16 -0400") Message-ID: <87sh8yqzub.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1exHHZ-0012PF-NF X-Source-Sender: 174-29-60-18.hlrn.qwest.net (bapiya) [174.29.60.18]:52496 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-03/txt/msg00339.txt.bz2 Simon> I suppose running the testsuite on macOS would test it? Though I'm not Simon> sure the current state of macOS support allows that... I don't have access to a Mac. Maybe if one were available the test suite could be run using lldb's gdbserver-like thing -- that would avoid the code-signing problem. >> + for (last_ix = ix; ix < oso_vector_ptr->size (); last_ix++) Simon> "ix < " or "last_ix < "? Ugh. Thanks. Another idea would be to check in a macho object file or two, just for smoke tests. Tom