From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/7] Use warn_unused_result on release methods
Date: Tue, 05 Mar 2019 15:46:00 -0000 [thread overview]
Message-ID: <87sgw1uxw9.fsf@tromey.com> (raw)
In-Reply-To: <20190227221814.17661-1-tromey@adacore.com> (Tom Tromey's message of "Wed, 27 Feb 2019 15:18:07 -0700")
>>>>> "Tom" == Tom Tromey <tromey@adacore.com> writes:
Tom> This applies the warn_unused_result attribute to various "release"
Tom> methods in gdb. The idea here is to avoid the bug where "release" is
Tom> used when "reset (nullptr)" is meant.
Tom> This caught one bug, so I consider it a success. Perhaps the new
Tom> attribute can be used elsewhere as well.
I'm checking this in now.
Tom
prev parent reply other threads:[~2019-03-05 15:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 22:18 Tom Tromey
2019-02-27 22:18 ` [PATCH 2/7] Add ATTRIBUTE_UNUSED_RESULT to parser_state Tom Tromey
2019-02-27 22:18 ` [PATCH 6/7] Add ATTRIBUTE_UNUSED_RESULT to scoped_remote_fd::release Tom Tromey
2019-02-27 22:18 ` [PATCH 3/7] Add ATTRIBUTE_UNUSED_RESULT to scoped_fd Tom Tromey
2019-02-27 22:18 ` [PATCH 1/7] Introduce ATTRIBUTE_UNUSED_RESULT and use it Tom Tromey
2019-02-27 22:18 ` [PATCH 7/7] Add ATTRIBUTE_UNUSED_RESULT to ref_ptr::release Tom Tromey
2019-02-27 22:26 ` [PATCH 0/7] Use warn_unused_result on release methods John Baldwin
2019-02-27 22:28 ` [PATCH 4/7] Add ATTRIBUTE_UNUSED_RESULT to scoped_mmap Tom Tromey
2019-02-28 7:41 ` Metzger, Markus T
2019-02-28 14:59 ` Tom Tromey
2019-02-27 22:28 ` [PATCH 5/7] Add ATTRIBUTE_UNUSED_RESULT to macro_buffer Tom Tromey
2019-03-05 15:46 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgw1uxw9.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox