From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: [PATCH 1/7] Introduce ATTRIBUTE_UNUSED_RESULT and use it
Date: Wed, 27 Feb 2019 22:18:00 -0000 [thread overview]
Message-ID: <20190227221814.17661-2-tromey@adacore.com> (raw)
In-Reply-To: <20190227221814.17661-1-tromey@adacore.com>
This introduces the new ATTRIBUTE_UNUSED_RESULT define, and applies it
to gdb_argv::release.
gdb/ChangeLog
2019-02-27 Tom Tromey <tromey@adacore.com>
* utils.h (class gdb_argv) <release>: Add
ATTRIBUTE_UNUSED_RESULT.
* common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
---
gdb/ChangeLog | 6 ++++++
gdb/common/common-defs.h | 6 ++++++
gdb/utils.h | 2 +-
3 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/gdb/common/common-defs.h b/gdb/common/common-defs.h
index 732693d65cc..6b1f004ab1b 100644
--- a/gdb/common/common-defs.h
+++ b/gdb/common/common-defs.h
@@ -93,6 +93,12 @@
#undef ATTRIBUTE_PRINTF
#define ATTRIBUTE_PRINTF _GL_ATTRIBUTE_FORMAT_PRINTF
+#if GCC_VERSION >= 3004
+#define ATTRIBUTE_UNUSED_RESULT __attribute__ ((__warn_unused_result__))
+#else
+#define ATTRIBUTE_UNUSED_RESULT
+#endif
+
#include "libiberty.h"
#include "pathmax.h"
#include "gdb/signals.h"
diff --git a/gdb/utils.h b/gdb/utils.h
index 896feb973c9..9dbd6386c68 100644
--- a/gdb/utils.h
+++ b/gdb/utils.h
@@ -188,7 +188,7 @@ public:
/* Return the underlying array, transferring ownership to the
caller. */
- char **release ()
+ ATTRIBUTE_UNUSED_RESULT char **release ()
{
char **result = m_argv;
m_argv = NULL;
--
2.20.1
next prev parent reply other threads:[~2019-02-27 22:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 22:18 [PATCH 0/7] Use warn_unused_result on release methods Tom Tromey
2019-02-27 22:18 ` [PATCH 7/7] Add ATTRIBUTE_UNUSED_RESULT to ref_ptr::release Tom Tromey
2019-02-27 22:18 ` [PATCH 3/7] Add ATTRIBUTE_UNUSED_RESULT to scoped_fd Tom Tromey
2019-02-27 22:18 ` [PATCH 2/7] Add ATTRIBUTE_UNUSED_RESULT to parser_state Tom Tromey
2019-02-27 22:18 ` [PATCH 6/7] Add ATTRIBUTE_UNUSED_RESULT to scoped_remote_fd::release Tom Tromey
2019-02-27 22:18 ` Tom Tromey [this message]
2019-02-27 22:26 ` [PATCH 0/7] Use warn_unused_result on release methods John Baldwin
2019-02-27 22:28 ` [PATCH 5/7] Add ATTRIBUTE_UNUSED_RESULT to macro_buffer Tom Tromey
2019-02-27 22:28 ` [PATCH 4/7] Add ATTRIBUTE_UNUSED_RESULT to scoped_mmap Tom Tromey
2019-02-28 7:41 ` Metzger, Markus T
2019-02-28 14:59 ` Tom Tromey
2019-03-05 15:46 ` [PATCH 0/7] Use warn_unused_result on release methods Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190227221814.17661-2-tromey@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox