From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107260 invoked by alias); 5 Mar 2019 15:46:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107252 invoked by uid 89); 5 Mar 2019 15:46:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.58.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Mar 2019 15:46:49 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway20.websitewelcome.com (Postfix) with ESMTP id B757E400EE90C for ; Tue, 5 Mar 2019 09:46:47 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 1CHHhsyXT4FKp1CHHh9gdP; Tue, 05 Mar 2019 09:46:47 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YgbrzTWku6jBz95WjlLeb2MUkj3Lej5R/2R7LVGlOjo=; b=C6KuTL9ewG6c2MJRmvracZm5+K MOseHEz5HN0EYUjbIZCJeiGbaw10yofvH8Hs+YVXh82FvSIBPyU1y883zBh5YSyAy9WpIb+QUaY9d abj0UPaJQC0b5VqoO0znLNfhg; Received: from 75-166-85-218.hlrn.qwest.net ([75.166.85.218]:52034 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h1CHH-003nwD-D3; Tue, 05 Mar 2019 09:46:47 -0600 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/7] Use warn_unused_result on release methods References: <20190227221814.17661-1-tromey@adacore.com> Date: Tue, 05 Mar 2019 15:46:00 -0000 In-Reply-To: <20190227221814.17661-1-tromey@adacore.com> (Tom Tromey's message of "Wed, 27 Feb 2019 15:18:07 -0700") Message-ID: <87sgw1uxw9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-03/txt/msg00051.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> This applies the warn_unused_result attribute to various "release" Tom> methods in gdb. The idea here is to avoid the bug where "release" is Tom> used when "reset (nullptr)" is meant. Tom> This caught one bug, so I consider it a success. Perhaps the new Tom> attribute can be used elsewhere as well. I'm checking this in now. Tom