From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/6] Remove some manual memory management from compile interface
Date: Wed, 23 Sep 2020 06:56:33 -0600 [thread overview]
Message-ID: <87sgb8ps72.fsf@tromey.com> (raw)
In-Reply-To: <266736d8-415c-b18e-507f-c8e5fbe84231@simark.ca> (Simon Marchi's message of "Sat, 19 Sep 2020 19:52:33 -0400")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>> This didn't result in any test result changes, but I didn't look to see
>> if this case is not tested or something like that.
Simon> Oh, I didn't realize that the change I proposed would change how we call
Simon> the function. What you ended up doing makes sense, if that's what's the
Simon> compiler library expects.
I dug even further and found out that the distinction doesn't matter on
the remote end:
static tree
start_class_def (tree type,
const gcc_vbase_array *base_classes)
{
tree bases = NULL;
if (base_classes)
{
for (int i = 0; i < base_classes->n_elements; i++)
{
So, I am going to change it back to your suggested approach and check it
in.
Tom
next prev parent reply other threads:[~2020-09-23 12:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-09 13:52 [PATCH 0/6] Avoid manual memory management in gdb/compile/ Tom Tromey
2020-08-09 13:52 ` [PATCH 1/6] Remove some manual memory management from compile interface Tom Tromey
2020-08-09 22:34 ` Simon Marchi
2020-09-19 23:45 ` Tom Tromey
2020-09-19 23:52 ` Simon Marchi
2020-09-23 12:56 ` Tom Tromey [this message]
2020-08-09 13:52 ` [PATCH 2/6] Use new/delete for do_module_cleanup Tom Tromey
2020-08-09 22:45 ` [PP?] " Simon Marchi
2020-09-23 13:36 ` Tom Tromey
2020-08-09 13:52 ` [PATCH 3/6] Introduce and use compile_module_up Tom Tromey
2020-08-09 13:52 ` [PATCH 4/6] Transfer module ownership to do_module_cleanup Tom Tromey
2020-08-10 0:48 ` [PP?] " Simon Marchi
2020-09-23 14:55 ` Tom Tromey
2020-08-09 13:52 ` [PATCH 5/6] Simplify compile_module cleanup Tom Tromey
2020-08-09 13:52 ` [PATCH 6/6] Avoid manual memory management of argv arrays in gdb/compile Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgb8ps72.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox