From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PP?] [PATCH 2/6] Use new/delete for do_module_cleanup
Date: Wed, 23 Sep 2020 07:36:18 -0600 [thread overview]
Message-ID: <87o8lwpqct.fsf@tromey.com> (raw)
In-Reply-To: <2f2630fa-fb4f-41ee-403b-92c7bde8ffe6@simark.ca> (Simon Marchi's message of "Sun, 9 Aug 2020 18:45:28 -0400")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>> struct do_module_cleanup
>> {
>> + do_module_cleanup () = default;
>> +
>> + ~do_module_cleanup ()
>> + {
>> + delete munmap_list_head;
>> + xfree (source_file);
>> + xfree (objfile_name_string);
>> + }
>> +
>> + DISABLE_COPY_AND_ASSIGN (do_module_cleanup);
>> +
Simon> Seeing this makes me a bit nervous, as it easily allows the destructor run on an object
Simon> whose fields have not been initialized. So it will call delete/xfree on uninitialized
Simon> pointers. So I'd rather introduce a constructor before introducing a destructor, or
Simon> simultaneously.
Makes sense. Because this gets reworked in later patches, I've added
initializers to these fields in this patch. That will avoid the
possibly-uninitialized problem here.
Tom
next prev parent reply other threads:[~2020-09-23 13:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-09 13:52 [PATCH 0/6] Avoid manual memory management in gdb/compile/ Tom Tromey
2020-08-09 13:52 ` [PATCH 1/6] Remove some manual memory management from compile interface Tom Tromey
2020-08-09 22:34 ` Simon Marchi
2020-09-19 23:45 ` Tom Tromey
2020-09-19 23:52 ` Simon Marchi
2020-09-23 12:56 ` Tom Tromey
2020-08-09 13:52 ` [PATCH 2/6] Use new/delete for do_module_cleanup Tom Tromey
2020-08-09 22:45 ` [PP?] " Simon Marchi
2020-09-23 13:36 ` Tom Tromey [this message]
2020-08-09 13:52 ` [PATCH 3/6] Introduce and use compile_module_up Tom Tromey
2020-08-09 13:52 ` [PATCH 4/6] Transfer module ownership to do_module_cleanup Tom Tromey
2020-08-10 0:48 ` [PP?] " Simon Marchi
2020-09-23 14:55 ` Tom Tromey
2020-08-09 13:52 ` [PATCH 5/6] Simplify compile_module cleanup Tom Tromey
2020-08-09 13:52 ` [PATCH 6/6] Avoid manual memory management of argv arrays in gdb/compile Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8lwpqct.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox