From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id E30uFFlPa1+5QQAAWB0awg (envelope-from ) for ; Wed, 23 Sep 2020 09:36:25 -0400 Received: by simark.ca (Postfix, from userid 112) id 23AED1EF4B; Wed, 23 Sep 2020 09:36:25 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A47AC1EDF4 for ; Wed, 23 Sep 2020 09:36:24 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C63AB39450EB; Wed, 23 Sep 2020 13:36:23 +0000 (GMT) Received: from gateway33.websitewelcome.com (gateway33.websitewelcome.com [192.185.145.216]) by sourceware.org (Postfix) with ESMTPS id 4274D39450EB for ; Wed, 23 Sep 2020 13:36:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4274D39450EB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway33.websitewelcome.com (Postfix) with ESMTP id A6A7938547 for ; Wed, 23 Sep 2020 08:36:20 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id L4wWkj08nBD8bL4wWktcDO; Wed, 23 Sep 2020 08:36:20 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vt1of9if4oY+YC5qaMt6XXhFUQMe4v1CGx1qdWjUtGc=; b=wdZc0Vn4D5eoJKXw4W0g5fNL3P EwdtLfpc12dhcazXnZVGjhj8mYw6ASR5xY1U5LXU5eMiGQdaHm9PtvNtw4zNhDE0xbBNrCySBLwAZ 0nk7o2d0ZKiXcBBxlsDMqKYZl; Received: from 75-166-120-119.hlrn.qwest.net ([75.166.120.119]:33834 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kL4wW-003vFA-5M; Wed, 23 Sep 2020 07:36:20 -0600 From: Tom Tromey To: Simon Marchi Subject: Re: [PP?] [PATCH 2/6] Use new/delete for do_module_cleanup References: <20200809135258.8207-1-tom@tromey.com> <20200809135258.8207-3-tom@tromey.com> <2f2630fa-fb4f-41ee-403b-92c7bde8ffe6@simark.ca> X-Attribution: Tom Date: Wed, 23 Sep 2020 07:36:18 -0600 In-Reply-To: <2f2630fa-fb4f-41ee-403b-92c7bde8ffe6@simark.ca> (Simon Marchi's message of "Sun, 9 Aug 2020 18:45:28 -0400") Message-ID: <87o8lwpqct.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.120.119 X-Source-L: No X-Exim-ID: 1kL4wW-003vFA-5M X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-120-119.hlrn.qwest.net (murgatroyd) [75.166.120.119]:33834 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Simon" == Simon Marchi writes: >> struct do_module_cleanup >> { >> + do_module_cleanup () = default; >> + >> + ~do_module_cleanup () >> + { >> + delete munmap_list_head; >> + xfree (source_file); >> + xfree (objfile_name_string); >> + } >> + >> + DISABLE_COPY_AND_ASSIGN (do_module_cleanup); >> + Simon> Seeing this makes me a bit nervous, as it easily allows the destructor run on an object Simon> whose fields have not been initialized. So it will call delete/xfree on uninitialized Simon> pointers. So I'd rather introduce a constructor before introducing a destructor, or Simon> simultaneously. Makes sense. Because this gets reworked in later patches, I've added initializers to these fields in this patch. That will avoid the possibly-uninitialized problem here. Tom