From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id jEtZNBNGa19zOAAAWB0awg (envelope-from ) for ; Wed, 23 Sep 2020 08:56:51 -0400 Received: by simark.ca (Postfix, from userid 112) id 438071EF68; Wed, 23 Sep 2020 08:56:50 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 770131EF6A for ; Wed, 23 Sep 2020 08:56:40 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B826D3857C4C; Wed, 23 Sep 2020 12:56:39 +0000 (GMT) Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.149.101]) by sourceware.org (Postfix) with ESMTPS id E574C3857C4C for ; Wed, 23 Sep 2020 12:56:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E574C3857C4C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 29CDBBEF9 for ; Wed, 23 Sep 2020 07:56:36 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id L4K4kK8CCPiqfL4K4kzLx8; Wed, 23 Sep 2020 07:56:36 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=w4UBJaa28G6bmTWQeAV9pj2tTtgMtF7M9wI0xDZ+bMY=; b=tQ+x0B54K3gLnTtaIMWZfhxWB2 xsBUHer+x0kXsUpzCBWjgFMw5UfUBnV0sFKnzOzAnlKqgQNXTSjLCVHHbXe8/qGyz4g7AeHyhTrxx mogPiECNFmFUjjtRDDzOefm/P; Received: from 75-166-120-119.hlrn.qwest.net ([75.166.120.119]:33510 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kL4K3-003KDh-Nn; Wed, 23 Sep 2020 06:56:35 -0600 From: Tom Tromey To: Simon Marchi Subject: Re: [PATCH 1/6] Remove some manual memory management from compile interface References: <20200809135258.8207-1-tom@tromey.com> <20200809135258.8207-2-tom@tromey.com> <6824ff00-ef2a-c1dc-8717-75111d3fd8b0@simark.ca> <87pn6h5o1s.fsf@tromey.com> <266736d8-415c-b18e-507f-c8e5fbe84231@simark.ca> X-Attribution: Tom Date: Wed, 23 Sep 2020 06:56:33 -0600 In-Reply-To: <266736d8-415c-b18e-507f-c8e5fbe84231@simark.ca> (Simon Marchi's message of "Sat, 19 Sep 2020 19:52:33 -0400") Message-ID: <87sgb8ps72.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.120.119 X-Source-L: No X-Exim-ID: 1kL4K3-003KDh-Nn X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-120-119.hlrn.qwest.net (murgatroyd) [75.166.120.119]:33510 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Simon" == Simon Marchi writes: >> This didn't result in any test result changes, but I didn't look to see >> if this case is not tested or something like that. Simon> Oh, I didn't realize that the change I proposed would change how we call Simon> the function. What you ended up doing makes sense, if that's what's the Simon> compiler library expects. I dug even further and found out that the distinction doesn't matter on the remote end: static tree start_class_def (tree type, const gcc_vbase_array *base_classes) { tree bases = NULL; if (base_classes) { for (int i = 0; i < base_classes->n_elements; i++) { So, I am going to change it back to your suggested approach and check it in. Tom