Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Use a newtype for remote file descriptor
Date: Fri, 27 Feb 2026 06:36:02 -0700	[thread overview]
Message-ID: <87seamux4t.fsf@tromey.com> (raw)
In-Reply-To: <3b326c61-0b46-491a-8217-a88a5741bd5b@simark.ca> (Simon Marchi's message of "Thu, 26 Feb 2026 11:38:59 -0500")

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> solib-rocm.c just needs one more change to build:

Simon> -      gdb_assert (it->second.fd != -1);
Simon> +      gdb_assert (it->second.fd != remote_fd::INVALID);

Thanks.

Simon> Calling it remote_fd in the context of ROCm is weird, since it's not
Simon> remote.  Perhaps call it target_fd?  It would make sense to me, since
Simon> it's the target file I/O interface.

I renamed it for v2.

Tom

  reply	other threads:[~2026-02-27 13:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25 21:25 [PATCH 0/2] Stronger typing for remote file i/o Tom Tromey
2026-02-25 21:25 ` [PATCH 1/2] Use a newtype for remote file descriptor Tom Tromey
2026-02-26 16:38   ` Simon Marchi
2026-02-27 13:36     ` Tom Tromey [this message]
2026-02-26 16:43   ` Simon Marchi
2026-02-27 13:36     ` Tom Tromey
2026-02-25 21:25 ` [PATCH 2/2] Use enum types for remote fileio flags Tom Tromey
2026-02-26 17:10   ` Simon Marchi
2026-02-27 14:15     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87seamux4t.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox