Re: [PATCH 1/2] Use a newtype for remote file descriptor

Tom Tromey
2026-02-27T13:36:33Z

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> solib-rocm.c just needs one more change to build:

Simon> - gdb_assert (it->second.fd != -1);
Simon> + gdb_assert (it->second.fd != remote_fd::INVALID);

Thanks.

Simon> Calling it remote_fd in the context of ROCm is weird, since it's not
Simon> remote. Perhaps call it target_fd? It would make sense to me, since
Simon> it's the target file I/O interface.

I renamed it for v2.

Tom