From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qb8vO+GdoWlkjQwAWB0awg (envelope-from ) for ; Fri, 27 Feb 2026 08:36:33 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=gg3cmu6W; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EBD5E1E0DD; Fri, 27 Feb 2026 08:36:33 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 03B6C1E089 for ; Fri, 27 Feb 2026 08:36:33 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 898554B9DB63 for ; Fri, 27 Feb 2026 13:36:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 898554B9DB63 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=gg3cmu6W Received: from mail-ot1-x332.google.com (mail-ot1-x332.google.com [IPv6:2607:f8b0:4864:20::332]) by sourceware.org (Postfix) with ESMTPS id 431F54BA23FA for ; Fri, 27 Feb 2026 13:36:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 431F54BA23FA Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 431F54BA23FA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::332 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772199367; cv=none; b=H34SmZUEitTJ03BpEV3+vEGbQ+M532y7NI/YLCTA1F0h/ot4rqxazzcg2mcetGrgY9Jvrfk06PPAEpl6RWOsnCoUut8cwNSFo8TLnb/Z+NHRRi732pPq22t4yprB/DRXmnxXFQa9bBq98ifOe2+VLUSZklv5Xmfc6K7KK66bqcs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772199367; c=relaxed/simple; bh=Ym/nL7IYqh2JQjYwGNDx/qCTDR2HOMsUoDc5DCVE5+o=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=gimpNTb/mgpSUE/TlqBGnVOMYw40BofCi1axfpKpQb6NrevZR+2YlCNZgk5v34p/8Km+CmVsFTfywDvr3l71oY2+eVw1ekKkE5lzb/0D+4ZjewAGfXyUWKtOwzZrMWiPpRfOqESOBoVB9LAaYdsNtkNphUimqk0T5LlLaMuaM3M= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 431F54BA23FA Received: by mail-ot1-x332.google.com with SMTP id 46e09a7af769-7d18f80b5c2so252434a34.3 for ; Fri, 27 Feb 2026 05:36:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1772199366; x=1772804166; darn=sourceware.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=jZoF4t3PeE43cFURILmYvllVbaq5X8CpWNOi19Ak3JI=; b=gg3cmu6Wxr4ACjO3H1z2rLpsxgXIChSzUoeFk39H5Bc93fX1YWt2MMeX1EHp3suatz NcKL3nf+nlyCM38oNT/dWGrVWrcQYjNeSaJAspEsfIKzD6ZSDfsnFWRkcpWqVtJCQ6vR 7fNFxVyMwTOXrIbpI1vdjcHsoS7WZZMyfm9yLqvC+eZBET12dlrBaqZwHBmI395rD2Jz 4cZHb/SR3HfZli75MsVT5s/j2Tua+TdkHkGdOd0eELmHMrEEOSXAhhTH1V2SqSpefcX1 pEvq2vujRTgf8/vi76An/CuKsu8hKtzhF+PgSr4lFJVoq9KIBRO+VdkkrZfri4OdJT3A lW/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772199366; x=1772804166; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=jZoF4t3PeE43cFURILmYvllVbaq5X8CpWNOi19Ak3JI=; b=pilyWNxm6C0kR2JcUZM6UvA9Lw5Svqprp+lRYGgN/Q5bD3LugcIBAnMDpM5gnVcQIp VyVeXiU6rhcNhwb631Eo0Vp9JXPc/Sr0NqTaG8Z+TZrvPk1nghgGcbYy4i6jDtOIN1Vt KGz64nI56UAyKi2V2Z6etCH3ZZq4o+RobVowBqZqIRKtK81JikIfoep3cCQM2bcPDaaw dKqAG2Bct7UqqQRxJv+2bWuLQifDiD93Nz/yWTyWyq66MIQNExd1TStC3dCcDPqSMyHd pH9O/bRUWL8oHnJvbBFxQCw2GFt/y6CH8uiY92TlV1UbaHOHoav9lOEPwKzqZgz9fYDm 5ElQ== X-Forwarded-Encrypted: i=1; AJvYcCWqWcF4KU93ofIdqwkT7qkk3CtgKIyWR1e6O3SaHzG4aLTNddj2lGRRvejN1P2Pf9cubNfDVpjgv6SiYg==@sourceware.org X-Gm-Message-State: AOJu0YxYn9XAfvbk4ysuPHOIKa2u4eB/r73bX9CorsdsWB46syI5u0hQ AyjzMfXJd00iVcrfXMKyvuCq/aslNUf8D4mUcm0UfMhXHFwEEa5WCzwOD3rI+phzTg== X-Gm-Gg: ATEYQzypeMw9Olpcd/Exnqp2eHgWRpPzcsFCiSYEm190rB9N7CGNZw+YnpcgIpd8mBR /Pxnm/Q5WGhqNwfoHc1oKRhwk//DK6EAb3dAztIfaOKVRvIVUf/nz+EQnH2NAtyr8FIkAInOpbS bcjHx6034QYxX2q9lSAjAaZmM/3f54/EE6AnxSiyBPsqOI0eVPe4TAizuF/Igs2GgKWivW7US1z QZS09rcVko1iRpTeXqf8rLvtJveK4xwhSE8BeMeNNrXc+6O9ZM7WbH6emQnmtXzlrRgHzH3fwny plCrUBQV0tgjgBK9vYQ30dBOVM4vHZtXs0+V8zSlsQJP5j1ctpdLERa9FHvxpwguPkgQ/drxZX6 6YnmhOMJ82T98w6LGbZ2hUmJweriauLw+W7xNmUarz2CdGfJdz0KYPuCs+C395yuXYd1WiiJ2UD PH4ffr3rT1YnSiyE/a7teSxIJBo6RjTgOzm4aO5gq6w0kIFg== X-Received: by 2002:a05:6830:6284:b0:7c7:4f2:e15d with SMTP id 46e09a7af769-7d591b45e06mr2120201a34.16.1772199366567; Fri, 27 Feb 2026 05:36:06 -0800 (PST) Received: from bapiya (97-122-122-234.hlrn.qwest.net. [97.122.122.234]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d5866541e5sm4268552a34.20.2026.02.27.05.36.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 05:36:05 -0800 (PST) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Use a newtype for remote file descriptor In-Reply-To: <3b326c61-0b46-491a-8217-a88a5741bd5b@simark.ca> (Simon Marchi's message of "Thu, 26 Feb 2026 11:38:59 -0500") References: <20260225-target-fd-newtype-v1-0-e04af6692ccb@adacore.com> <20260225-target-fd-newtype-v1-1-e04af6692ccb@adacore.com> <3b326c61-0b46-491a-8217-a88a5741bd5b@simark.ca> X-Attribution: Tom Date: Fri, 27 Feb 2026 06:36:02 -0700 Message-ID: <87seamux4t.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> solib-rocm.c just needs one more change to build: Simon> - gdb_assert (it->second.fd != -1); Simon> + gdb_assert (it->second.fd != remote_fd::INVALID); Thanks. Simon> Calling it remote_fd in the context of ROCm is weird, since it's not Simon> remote. Perhaps call it target_fd? It would make sense to me, since Simon> it's the target file I/O interface. I renamed it for v2. Tom