Re: [PATCH 1/1] gdb: set the cache information in 'get_prev_frame_maybe_check_cycle'

[Tom Tromey <tom@tromey.com>]

>>>>> Stephan Rohr <stephan.rohr@intel.com> writes:

> From: "Rohr, Stephan" <stephan.rohr@intel.com>
> 'get_prev_frame_maybe_check_cycle' retrieves the previous frame and
> computes the frame id.  At this point, the frame id is not cached yet,
> which prevents the frame from being reinflated once the frane cache is

s/frane/frame/

>   1. Build the 'prev_frame' and eventually calls
>      'get_prev_frame_maybe_check_cycle'.  The frame_id is only computed
>      for the raw frame pointer, the wrapping 'frame_info_ptr' it not
>      updated.

s/it not/is not/

> +  /* No cycle and the frame is added to the frame stash, update the cache
> +     information to ensure the frame can be reinflated after the cache is
> +     flushed.  */
> +  if (prev_frame)
> +    prev_frame.update_cache ();
> +

I wonder if some other approach could be taken here.
It seems unfortunate to have to add a new public method to this class
just to work around some sort of ordering issue.

That said I'm not sure I understand the problem well enough to suggest a
better solution.  Like should maybe get_prev_frame_raw not return a
frame_info_ptr?  And then the frame_info_ptr be created after the call
to frame_stash_add in get_prev_frame_maybe_check_cycle?

Tom