From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2bpuJq2VPmpdXBkAWB0awg (envelope-from ) for ; Fri, 26 Jun 2026 11:07:25 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=I48nR2uN; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 995201E098; Fri, 26 Jun 2026 11:07:25 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AC42E1E024 for ; Fri, 26 Jun 2026 11:07:24 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C9FBD4BA2E3B for ; Fri, 26 Jun 2026 15:07:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C9FBD4BA2E3B Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=I48nR2uN Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id B6F504BA5435 for ; Fri, 26 Jun 2026 15:06:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B6F504BA5435 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B6F504BA5435 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1782486418; cv=none; b=T67r1SUC9+3NtC0Ao8KPLOTADsiE/Meb4mFreJJenPGRbfH7U4cKZyVfktekq/q5K6mUmLld+EhcgU9KcRFkDkHR15cs4diKJCOvJ+hlqiTvJH1H60ZmfoVZ/0Qk0Xj7c1L83B5yebkDeEfWIjkzVKX8wWAn4H8dYE15FBT1Bks= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1782486418; c=relaxed/simple; bh=WMksrXE2vHnZvM6ku9iONoabO7OaMWJHBRf0K1FInMI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=YOHjX/nH+ORN6ysZyzreEBqcdknmrZ0m+4hxcrtdv+hSayutq80I+4YS1Bcvb5lAj+fMCx60E1t+XxnVwKj3RSADecPuP0XaMyqo4tfXd/63gE62MPiitUoLVcxA9t3tIlchk06ggpgmMAgbBeepM7DnRWLneQ68pcwqh7CgzfA= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=I48nR2uN reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B6F504BA5435 Received: from eig-obgw-5001b.ext.cloudfilter.net ([10.0.29.181]) by cmsmtp with ESMTPS id d6pIwxNh7MFEgd88vwqmSl; Fri, 26 Jun 2026 15:06:57 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id d88uwNEqt3kw8d88vwpTqj; Fri, 26 Jun 2026 15:06:57 +0000 X-Authority-Analysis: v=2.4 cv=F+VXdrhN c=1 sm=1 tr=0 ts=6a3e9591 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=FelO9ux0wxsA:10 a=ItBw4LHWJt0A:10 a=QyXUC8HyAAAA:8 a=nx-5-OKERdPqqNROS3kA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Bn6t2umGPbKn6Txws7ETFJlr3w6iFgQ1HMEwF7wXODk=; b=I48nR2uNurCewRK8FL2h0uonOc aUaU7DzAnfi2z3PeDIrVBkMkEw1MglG4/WlJ4R2sHYkUAlLdWts37+ju0EHV6tgkr4G3RAmiqRsgH RYFCMnVEngkkhTFVTkSAcaUes; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:44682 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wd88u-000000004z3-2Fgl; Fri, 26 Jun 2026 09:06:56 -0600 From: Tom Tromey To: Stephan Rohr Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/1] gdb: set the cache information in 'get_prev_frame_maybe_check_cycle' In-Reply-To: <20260625145850.3104079-2-stephan.rohr@intel.com> (Stephan Rohr's message of "Thu, 25 Jun 2026 14:58:50 +0000") References: <20260625145850.3104079-1-stephan.rohr@intel.com> <20260625145850.3104079-2-stephan.rohr@intel.com> X-Attribution: Tom Date: Fri, 26 Jun 2026 09:06:46 -0600 Message-ID: <87se69wdbt.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wd88u-000000004z3-2Fgl X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:44682 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDjsiWsFU5JARZHRCTBaZymQFOXF5k+Ouddw41u7AnmHsenXlUAn0YvM8hiXV9BsOIHM0NBmaexMJyxw1EWLIMhYoIbmCq7Jm4SdZ1gJlRj5wuvKBIIC cbt9E43pbeJw+a3k8anrv7p/+XZwyWZi/2pzLBPnLT0A5gyPb2hn+kY2gDj76rXb8MupzrrEaJM1QZP94A/iwzaWK0fMrFUoBJs= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Stephan Rohr writes: > From: "Rohr, Stephan" > 'get_prev_frame_maybe_check_cycle' retrieves the previous frame and > computes the frame id. At this point, the frame id is not cached yet, > which prevents the frame from being reinflated once the frane cache is s/frane/frame/ > 1. Build the 'prev_frame' and eventually calls > 'get_prev_frame_maybe_check_cycle'. The frame_id is only computed > for the raw frame pointer, the wrapping 'frame_info_ptr' it not > updated. s/it not/is not/ > + /* No cycle and the frame is added to the frame stash, update the cache > + information to ensure the frame can be reinflated after the cache is > + flushed. */ > + if (prev_frame) > + prev_frame.update_cache (); > + I wonder if some other approach could be taken here. It seems unfortunate to have to add a new public method to this class just to work around some sort of ordering issue. That said I'm not sure I understand the problem well enough to suggest a better solution. Like should maybe get_prev_frame_raw not return a frame_info_ptr? And then the frame_info_ptr be created after the call to frame_stash_add in get_prev_frame_maybe_check_cycle? Tom